From: gmbnomis@gmail•com (Simon Baatz)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V3 00/10] mmc_of_parse() adaptations, DT support for Sheevaplugs
Date: Wed, 22 May 2013 21:25:02 +0200 [thread overview]
Message-ID: <20130522192501.GC25367@schnuecks.de> (raw)
In-Reply-To: <20130521131455.GP31290@titan.lakedaemon.net>
Hi Jason,
On Tue, May 21, 2013 at 09:14:55AM -0400, Jason Cooper wrote:
> On Tue, May 21, 2013 at 01:01:41AM +0200, Simon Baatz wrote:
> > Hi,
> >
> > V3 changes:
> > - Patch 01/10: Added EPROBE_DEFER case to mmc_of_parse()
> > - Added Acked-By to (unmodified) patches 02 and 03.
> >
> > V2 changes:
> > - Converted mvsdio to use mmc_of_parse()
> > - Adapted DTS files using mvsdio accordingly
> > - Changed mmc_of_parse() to return errors to the caller
> >
> > While adding DT support for the Sheevaplugs by Globalscale Technologies
> > (Kirkwood), it turned out that the DT binding of mvsdio lacked features to
> > properly support the hardware (active high/low of CD and WP pins could not
> > be described in DT).
> >
> > This is standard functionality provided by the mmc_of_parse() helper
> > function. However, mmc_of_parse() may allocate GPIO lines. If the
> > allocation fails, it outputs an error, but does not return an error to its
> > caller. Therefore, a proposal to handle errors in mmc_of_parse() is made.
> >
> > The patch set is structured as follows:
> >
> > 1 Adapt mmc_of_parse() to return errors
> > 2-6 Handle errors in current drivers using mmc_of_parse() (compile tested
> > only)
> > 7-8 Convert mvsdio and respective dts files to mmc_of_parse() (tested on
> > kirkwood)
> > 9 Add dts files for (eSATA) Sheevaplug
> > 10 Add DT support for (eSATA) Sheevaplug
>
> Patches 7, 9, and 10 already pulled into mvebu/dt. You can drop those
> from this series if you need to do another revision.
If you don't mind too much, as this crosses two trees, I would prefer
to keep the series "self-contained" if people want to test.
Additionally, I have two Acked-bys for 9 and 10 from Andrew that are
not part of the patches yet.
> > I could only test on an eSATA Sheevaplug. I found patches with
> > different LEDs for the Sheevaplug. Thus, I would highly appreciate if
> > someone with the hardware could give this a spin on a non-eSATA
> > version.
>
> I happen to have one. Unfortunately, it is currently my primary email
> server, dhcp, dns, file server, and a few other irreplaceable things. :(
> I *really* need to upgrade/reconfigure ...
Even without reinstalling, can you please have a look if your
"plug:green:health" LED is really green (mine is blue)? And if your
kernel already has a "plug:red:misc" LED could you verify whether it
is really there? Do you happen to know which board revision you
have?
Thanks,
Simon
next prev parent reply other threads:[~2013-05-22 19:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 23:01 [PATCH V3 00/10] mmc_of_parse() adaptations, DT support for Sheevaplugs Simon Baatz
2013-05-20 23:01 ` [PATCH V3 01/10] mmc: return mmc_of_parse() errors to caller Simon Baatz
2013-05-21 7:00 ` Ulf Hansson
2013-05-20 23:01 ` [PATCH V3 02/10] mmc: sh_mmcif: handle mmc_of_parse() errors during probe Simon Baatz
2013-05-20 23:01 ` [PATCH V3 03/10] mmc: tmio-mmc: " Simon Baatz
2013-05-20 23:01 ` [PATCH V3 04/10] mmc: mxcmmc: " Simon Baatz
2013-05-20 23:01 ` [PATCH V3 05/10] mmc: sdhci-pxav3: " Simon Baatz
2013-05-20 23:01 ` [PATCH V3 06/10] mmc: tegra: " Simon Baatz
2013-05-20 23:01 ` [PATCH V3 07/10] ARM: mvebu: Use standard MMC binding for all users of mvsdio Simon Baatz
2013-05-20 23:01 ` [PATCH V3 08/10] mmc: mvsdio: use standard MMC device-tree binding parser mmc_of_parse() Simon Baatz
2013-05-20 23:01 ` [PATCH V3 09/10] ARM: Kirkwood: Add dts files for Sheevaplug and eSATA Sheevaplug Simon Baatz
2013-05-21 5:11 ` Andrew Lunn
2013-05-20 23:01 ` [PATCH V3 10/10] ARM: Kirkwood: add DT support for Sheevaplug and Sheevaplug eSATA Simon Baatz
2013-05-21 5:13 ` Andrew Lunn
2013-05-21 13:14 ` [PATCH V3 00/10] mmc_of_parse() adaptations, DT support for Sheevaplugs Jason Cooper
2013-05-22 19:25 ` Simon Baatz [this message]
2013-05-23 11:23 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522192501.GC25367@schnuecks.de \
--to=gmbnomis@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox