From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework
Date: Tue, 18 Jun 2013 16:01:16 +0200 [thread overview]
Message-ID: <201306181601.16795.arnd@arndb.de> (raw)
In-Reply-To: <CANuQgHHoUyE5e+MnnpzWLxcFNcD11FjYwx76pucw7peV4qmFkQ@mail.gmail.com>
On Tuesday 18 June 2013, Chander Kashyap wrote:
> >> + [Core Clocks]
> >> +
> >> + Clock ID
> >> + ----------------------------
> >> +
> >> + fin_pll 1
> >> +
> >> + [Clock Gate for Special Clocks]
> >> +
> >> + Clock ID
> >> + ----------------------------
> >> + sclk_uart0 128
> >> + sclk_uart1 129
> >> + sclk_uart2 130
> >
> >> +
> >> + [Peripheral Clock Gates]
> >> +
> >> + Clock ID
> >> + ----------------------------
> >> +
> >> + aclk66_peric 256
> >> + uart0 257
> >> + uart1 258
> >
> > It looks like these are actually separate things. Wouldn't it be more sensible
> > to have separate device nodes for each of the lists and use a local index?
> I have listed the parent clock first, then the child clocks, to
> maintain readability.
> >
> > What numbers are used in the data sheet?
> I didn't get your point?
I would have expected three clock device nodes, one for fin_pll (presumably a
fixed-rate clock?), one for "special clocks" and one for "peripheral clock
gates", and a number space starting at '1' for each of them, rather than
having a shared node and numbers starting at '1', '128' and '256', which looks
a bit clumsy.
Did you take the ID number definitions from a data sheet, or did you make up
the numbers yourself for the purpose of defining a binding?
Arnd
next prev parent reply other threads:[~2013-06-18 14:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 11:00 [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 01/10] ARM: dts: fork out common Exynos5 nodes Chander Kashyap
2013-06-17 11:38 ` Kukjin Kim
2013-06-18 4:24 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 02/10] ARM: dts: list the CPU nodes for Exynos5250 Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 03/10] ARM: Exynos: Add support for Exynos5420 SoC Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 04/10] serial: samsung: select Exynos specific driver data if ARCH_EXYNOS is defined Chander Kashyap
2013-06-17 11:45 ` Kukjin Kim
2013-06-18 10:31 ` Kukjin Kim
2013-06-18 15:19 ` 'Greg Kroah-Hartman'
2013-06-17 11:00 ` [PATCH v3 05/10] ARM: Exynos: use four additional chipid bits to identify Exynos family Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 06/10] clk: exynos5420: register clocks using common clock framework Chander Kashyap
2013-06-17 11:49 ` Kukjin Kim
2013-06-17 12:27 ` Arnd Bergmann
2013-06-18 4:09 ` Chander Kashyap
2013-06-18 14:01 ` Arnd Bergmann [this message]
2013-06-18 14:26 ` Tomasz Figa
2013-06-18 17:13 ` Arnd Bergmann
2013-06-17 11:00 ` [PATCH v3 07/10] ARM: dts: Add initial device tree support for Exynos5420 Chander Kashyap
2013-06-17 11:44 ` Tomasz Figa
2013-06-18 4:21 ` Chander Kashyap
2013-06-18 7:36 ` Tomasz Figa
2013-06-17 11:00 ` [PATCH v3 08/10] clocksource: exynos_mct: use (request/free)_irq calls for local timer registration Chander Kashyap
2013-06-17 11:53 ` Kukjin Kim
2013-06-18 4:11 ` Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 09/10] ARM: Exynos: add secondary CPU boot base location for Exynos5420 Chander Kashyap
2013-06-17 11:00 ` [PATCH v3 10/10] ARM: Exynos: extend soft-reset support " Chander Kashyap
2013-06-17 12:21 ` Arnd Bergmann
2013-06-18 4:10 ` Chander Kashyap
2013-06-17 11:45 ` [PATCH v3 00/10] ARM: Exynos: Add Exynos5420 SoC support Tomasz Figa
2013-06-17 11:56 ` Kukjin Kim
2013-06-18 4:28 ` Chander Kashyap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306181601.16795.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox