public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 4/4] arm: add basic support for Rockchip RK3066a boards
Date: Tue, 18 Jun 2013 16:13:16 +0200	[thread overview]
Message-ID: <201306181613.16911.arnd@arndb.de> (raw)
In-Reply-To: <201306180026.25973.heiko@sntech.de>

On Tuesday 18 June 2013, Heiko St?bner wrote:
> > Side comment: I think it would be nice if the generic code did this
> > init if a l2x0 device node was in the device tree, since the only
> > reason to override init_machine is to do this call in addition to
> > of_platform_populate().
> 
> Arnd said similar things in the initial version :-).
> 
> Currently I'm wondering if it wouldn't be enough to call always l2x0_of_init 
> somewhere, because it does the checking for the dt nodes itself already.
> 
> The only obstacle would be platforms having the need to use special aux-values 
> or which are currently calling the function from some other parts of the boot 
> process (tegra inits the cache in its tegra_init_early function for example).

I think we can handle this by ensuring the function only gets called once,
and all platforms with special requirements call it before the common code
does.

I tried to understand what the requirement for non-zero argument is however
and couldn't figure it out. Shouldn't we just be able to specify all the
bits as DT properties all the time?

	Arnd

      reply	other threads:[~2013-06-18 14:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-13 14:58 [PATCH v4 0/4] arm: add basic support for Rockchip Cortex-A9 SoCs Heiko Stübner
2013-06-13 14:59 ` [PATCH v4 1/4] clk: add support for Rockchip gate clocks Heiko Stübner
2013-06-20 23:29   ` Mike Turquette
2013-06-13 15:00 ` [PATCH v4 2/4] arm: Add basic clocks for Rockchip rk3066a SoCs Heiko Stübner
2013-06-13 15:00 ` [PATCH v4 3/4] arm: add debug uarts for rockchip rk29xx and rk3xxx series Heiko Stübner
2013-06-13 15:02 ` [PATCH v4 4/4] arm: add basic support for Rockchip RK3066a boards Heiko Stübner
2013-06-17 21:35   ` Olof Johansson
2013-06-17 22:26     ` Heiko Stübner
2013-06-18 14:13       ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201306181613.16911.arnd@arndb.de \
    --to=arnd@arndb$(echo .)de \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox