From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes
Date: Wed, 19 Jun 2013 14:03:20 +0200 [thread overview]
Message-ID: <201306191403.20569.arnd@arndb.de> (raw)
In-Reply-To: <20130618220929.GA24056@localhost>
On Wednesday 19 June 2013, Ezequiel Garcia wrote:
> On Tue, Jun 18, 2013 at 06:16:26PM +0200, Arnd Bergmann wrote:
> > On Tuesday 18 June 2013, Ezequiel Garcia wrote:
> > >
> > > + devbus-bootcs {
> > > + compatible = "marvell,mvebu-devbus";
> > > + reg = <0xffff0001 0x10400 0x8>;
> > > + ranges = <0 MBUS_ID(0x01, 0x2f) 0 0xffffffff>;
> > > + #address-cells = <1>;
> > > + #size-cells = <1>;
> > > + clocks = <&coreclk 0>;
> > > + status = "disabled";
> > > + };
> >
> > This is a violation of the binding as far as I can tell, since you don't specify ranges
> > to access the 0xffff0001 0x10400 address. However, as I explained in my comment for
> > the binding, I think you should clarify the binding and leave the implementation
> > as you have it here.
> >
>
> Mmm... again I got lost here. Which 'ranges' you say I don't specify to
> access the (formerly) 0xffff0001?
>
> AFAIK, 'ranges' are only for children translation, which means I don't
> need to specify a ranges for that in the devbus node, but in its parent,
> right?
>
> This ranges thing can be very tricky, so please correct me if I'm
> mistaken.
You already clarified that the binding was wrong. This was about the
part where you replied:
>> Do you really want to require the child to provide a "ranges" property?
>> I think this makes it more complicated to specify devices that belong
>> into the "internal-regs" category.
>>
>
>No, this text is actually a left-over from the previous patchset, in
>current v3 patchset MBus children are not required to have any ranges.
>On the otherside, although you will need one except in the most trivial
>cases like for the BootROM.
With that change, everything above is ok.
Arnd
next prev parent reply other threads:[~2013-06-19 12:03 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 11:25 [PATCH v3 00/12] MBus device tree binding Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 01/12] bus: mvebu-mbus: Factor out initialization details Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 02/12] bus: mvebu-mbus: Introduce device tree binding Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 03/12] bus: mvebu-mbus: Add static window allocation to the DT binding Ezequiel Garcia
2013-06-18 16:14 ` Arnd Bergmann
2013-06-18 17:12 ` Thomas Petazzoni
2013-06-18 17:16 ` Arnd Bergmann
2013-06-18 21:34 ` Ezequiel Garcia
2013-06-18 21:45 ` Arnd Bergmann
2013-06-19 18:52 ` Ezequiel Garcia
2013-06-19 19:08 ` Arnd Bergmann
2013-06-19 19:29 ` Ezequiel Garcia
2013-06-19 19:37 ` Jason Cooper
2013-06-18 17:46 ` Jason Gunthorpe
2013-06-18 18:24 ` Sebastian Hesselbarth
2013-06-18 18:39 ` Arnd Bergmann
2013-06-18 18:44 ` Sebastian Hesselbarth
2013-06-18 18:47 ` Jason Gunthorpe
2013-06-18 18:59 ` Sebastian Hesselbarth
2013-06-18 19:10 ` Jason Gunthorpe
2013-06-18 19:27 ` Sebastian Hesselbarth
2013-06-18 20:49 ` Ezequiel Garcia
2013-06-18 20:55 ` Jason Gunthorpe
2013-06-18 21:10 ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 04/12] ARM: mvebu: Initialize MBus using " Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 05/12] ARM: mvebu: Remove the harcoded BootROM window allocation Ezequiel Garcia
2013-06-18 17:39 ` Jason Gunthorpe
2013-06-18 19:43 ` Ezequiel Garcia
2013-06-18 19:51 ` Jason Gunthorpe
2013-06-18 20:02 ` Ezequiel Garcia
2013-06-18 20:10 ` Jason Gunthorpe
2013-06-18 20:39 ` Ezequiel Garcia
2013-06-19 10:02 ` Ezequiel Garcia
2013-06-19 16:58 ` Jason Gunthorpe
2013-06-19 17:58 ` Ezequiel Garcia
2013-06-19 18:03 ` Jason Gunthorpe
2013-06-19 18:17 ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 06/12] memory: mvebu-devbus: Remove address decoding window workaround Ezequiel Garcia
2013-06-18 11:39 ` Jason Cooper
2013-06-18 12:17 ` Thomas Petazzoni
2013-06-18 12:33 ` Jason Cooper
2013-06-18 12:48 ` Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 07/12] ARM: mvebu: Use the preprocessor on Armada 370/XP device tree files Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 08/12] ARM: mvebu: Add MBus to Armada 370/XP device tree Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 09/12] ARM: mvebu: Add BootROM " Ezequiel Garcia
2013-06-18 11:25 ` [PATCH v3 10/12] ARM: mvebu: Relocate Armada 370/XP DeviceBus device tree nodes Ezequiel Garcia
2013-06-18 16:16 ` Arnd Bergmann
2013-06-18 22:09 ` Ezequiel Garcia
2013-06-18 22:14 ` Ezequiel Garcia
2013-06-19 12:03 ` Arnd Bergmann [this message]
2013-06-18 11:25 ` [PATCH v3 11/12] ARM: mvebu: Relocate Armada 370 PCIe " Ezequiel Garcia
2013-06-18 16:29 ` Arnd Bergmann
2013-06-18 17:15 ` Thomas Petazzoni
2013-06-18 17:18 ` Arnd Bergmann
2013-06-18 17:21 ` Thomas Petazzoni
2013-06-18 18:22 ` Arnd Bergmann
2013-06-18 19:02 ` Jason Gunthorpe
2013-06-18 21:20 ` Arnd Bergmann
2013-06-18 21:40 ` Ezequiel Garcia
2013-06-19 12:06 ` Arnd Bergmann
2013-06-18 21:35 ` Arnd Bergmann
2013-06-19 11:12 ` Ezequiel Garcia
2013-06-19 12:11 ` Arnd Bergmann
2013-06-19 16:53 ` Jason Gunthorpe
2013-06-19 18:55 ` Arnd Bergmann
2013-06-18 11:25 ` [PATCH v3 12/12] ARM: mvebu: Relocate Armada XP " Ezequiel Garcia
2013-06-18 11:33 ` [PATCH v3 00/12] MBus device tree binding Sebastian Hesselbarth
2013-06-18 13:07 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306191403.20569.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox