Subject: [PATCH 1/2] clk: nomadik: implement the Nomadik clocks properly

From: [email-masked] (Mike Turquette)
Date: Wed, 19 Jun 2013 23:38:01 -0700

Quoting Linus Walleij (2013-06-09 03:55:47)
> +static void pll_clk_disable(struct clk_hw *hw)
> +{
> +       struct clk_pll *pll = to_pll(hw);
> +       u32 val;
> +
> +       return;

Is the early return intentional? Everything else looks good.

Acked-by: Mike Turquette <[email-masked]>

> +
> +       spin_lock(&src_lock);
> +       val = readl(src_base + SRC_PLLCR);
> +       if (pll->id == 1) {
> +               if (val & SRC_PLLCR_PLL1OVER) {
> +                       val &= ~SRC_PLLCR_PLL1EN;
> +                       writel(val, src_base + SRC_PLLCR);
> +               }
> +       } else if (pll->id == 2) {
> +               val &= ~SRC_PLLCR_PLL2EN;
> +               writel(val, src_base + SRC_PLLCR);
> +       }
> +       spin_unlock(&src_lock);
> +}