From: mturquette@linaro•org (Mike Turquette)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] clk: Handle CLK_GET_RATE_NOCACHE flag in clk_set_rate()
Date: Fri, 21 Jun 2013 09:16:27 -0700 [thread overview]
Message-ID: <20130621161627.9136.84494@quantum> (raw)
In-Reply-To: <1371820055-14147-1-git-send-email-s.nawrocki@samsung.com>
Quoting Sylwester Nawrocki (2013-06-21 06:07:35)
> If a clock has CLK_GET_RATE_NOCACHE flag set the rate needs to
> be recalculated, rather than referencing the cached value.
>
> Currently cached clk->rate is compared with new value to see if
> anything needs to be done in clk_set_rate(). This may cause required
> clock controller registers update to not happen when same clock
> frequency value is being set subsequently.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung•com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung•com>
Peter already sent a patch for this:
https://git.linaro.org/gitweb?p=people/mturquette/linux.git;a=commitdiff;h=34e452a152efd25d654b7bc809df429337115b03
Regards,
Mike
> ---
> drivers/clk/clk.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 1144e8c..ffa304e 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -1215,6 +1215,9 @@ int clk_set_rate(struct clk *clk, unsigned long rate)
> /* prevent racing with updates to the clock topology */
> clk_prepare_lock();
>
> + if (clk->flags & CLK_GET_RATE_NOCACHE)
> + __clk_recalc_rates(clk, 0);
> +
> /* bail early if nothing to do */
> if (rate == clk->rate)
> goto out;
> --
> 1.7.9.5
next prev parent reply other threads:[~2013-06-21 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 13:07 [PATCH] clk: Handle CLK_GET_RATE_NOCACHE flag in clk_set_rate() Sylwester Nawrocki
2013-06-21 16:16 ` Mike Turquette [this message]
2013-06-24 18:42 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621161627.9136.84494@quantum \
--to=mturquette@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox