From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression
Date: Tue, 25 Jun 2013 00:04:32 -0700 [thread overview]
Message-ID: <20130625070432.GB5523@atomide.com> (raw)
In-Reply-To: <CACxGe6vRCjyJgX+dgKuJREvFf_btjhSkfqDnYekuDfkVW7pRQg@mail.gmail.com>
* Grant Likely <grant.likely@secretlab•ca> [130624 09:00]:
> On Mon, Jun 24, 2013 at 8:21 AM, Tony Lindgren <tony@atomide•com> wrote:
> > * Javier Martinez Canillas <martinez.javier@gmail•com> [130623 18:08]:
> >> On Mon, Jun 24, 2013 at 1:43 AM, Aaro Koskinen <aaro.koskinen@iki•fi> wrote:
> >> > Hi,
> >> >
> >> > On Mon, Jun 24, 2013 at 01:06:37AM +0200, Javier Martinez Canillas wrote:
> >> >> On Mon, Jun 24, 2013 at 12:16 AM, Aaro Koskinen <aaro.koskinen@iki•fi> wrote:
> >> >> > What is the status of this patch? We're already at 3.10-rc7 and GPIO
> >> >> > IRQs are still broken on OMAP1.
> >> >
> >> > [...]
> >> >
> >> >> There is a problem with this patch.
> >> >
> >> > [...]
> >> >
> >> >> So I think that the correct solution is to add SPARSE_IRQ support to
> >> >> omap1 and not reverting Jon's patch. Of course this may not be
> >> >> possible since we are so close to 3.10 and most OMAP patches already
> >> >> merged for 3.11 but we should definitely try to have this at least for
> >> >> 3.12. Otherwise we won't be able to move to DT-only booting for
> >> >> OMAP2+.
> >> >
> >> > OMAP1 does not use DT. So we could put this code under #ifdef
> >> > CONFIG_ARCH_OMAP1 or similar. It's just a few lines of code. OMAP2+
> >> > work should not regress OMAP1.
> >> >
> >> > Demanding SPARSE_IRQ support for OMAP1 should have been discussed before
> >> > these changes were made. It's not reasonable to assume such things can
> >> > be made during rc-cycle. Also, now, I don't think it's reasonable to
> >> > wait for that to be done, as it would take until 3.12 or even later to
> >> > get OMAP1 functional again.
> >> >
> >> > A.
> >>
> >> Hi,
> >>
> >> Yes, since we are so late in the -rc cycle and OMAP1 is currently
> >> broken I agree that the only sensible solution is to revert the patch
> >> for now.
> >
> > Agreed.
> >
> >> I just wanted to point out the issue that keeping the OMAP GPIO driver
> >> using legacy mapping domain represents a blocker to have GPIO-IRQ
> >> working with Device Tree for OMAP2+
> >
> > Yes. We can do the ifdef Aaro suggested, and let's also plan on
> > converting omap1 to use SPARSE_IRQ. But with the ifdef we can cut
> > away the dependency between these two.
>
> Alright. Sorry I dropped the ball on this one. I've lost track of
> which patch needs to get applied, but given that it is so late in the
> cycle, it would be better for someone else to apply the change, test
> and send a pull request to Linus. I'm okay with it going through the
> OMAP tree if that is the most expedient. Alternately, send me the pull
> request and I'll pass it on to Linus.
OK, I'll wait for Aaro's ack on Javier's patch and then put it into a
branch for you.
Regards,
Tony
next prev parent reply other threads:[~2013-06-25 7:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 20:53 [BISECTED] 3.10-rc1 OMAP1 GPIO IRQ regression Aaro Koskinen
2013-05-16 18:09 ` Tony Lindgren
2013-05-16 21:00 ` Aaro Koskinen
2013-05-16 21:44 ` Tony Lindgren
2013-05-20 17:46 ` Tony Lindgren
2013-05-21 17:39 ` Aaro Koskinen
2013-05-21 19:37 ` Jon Hunter
2013-05-22 21:20 ` Aaro Koskinen
2013-05-23 19:02 ` Jon Hunter
2013-05-23 20:13 ` Aaro Koskinen
2013-05-28 18:41 ` Jon Hunter
2013-05-26 19:07 ` Aaro Koskinen
2013-05-28 18:42 ` Jon Hunter
2013-05-29 18:55 ` Aaro Koskinen
2013-05-29 21:29 ` Jon Hunter
2013-05-29 22:41 ` Jon Hunter
2013-06-05 22:33 ` Grant Likely
2013-06-06 15:53 ` Tony Lindgren
2013-06-23 22:16 ` Aaro Koskinen
2013-06-23 23:06 ` Javier Martinez Canillas
2013-06-23 23:43 ` Aaro Koskinen
2013-06-24 1:01 ` Javier Martinez Canillas
2013-06-24 7:21 ` Tony Lindgren
2013-06-24 15:35 ` Javier Martinez Canillas
2013-06-25 18:14 ` Aaro Koskinen
2013-06-24 15:53 ` Grant Likely
2013-06-25 7:04 ` Tony Lindgren [this message]
2013-06-25 11:49 ` Grant Likely
2013-06-26 7:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130625070432.GB5523@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox