From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/4] arm: omap5: hwmod: add missing ocp2scp hwmod data
Date: Tue, 16 Jul 2013 05:24:32 -0700 [thread overview]
Message-ID: <20130716122432.GX7656@atomide.com> (raw)
In-Reply-To: <20130715154603.GC32035@arwen.pp.htv.fi>
* Felipe Balbi <balbi@ti•com> [130715 08:52]:
> On Mon, Jul 15, 2013 at 09:13:32PM +0530, Kishon Vijay Abraham I wrote:
> > Hi,
> >
> > On Monday 15 July 2013 09:03 PM, Felipe Balbi wrote:
> > > From: Benoit Cousson <benoit.cousson@linaro•org>
> > >
> > > without that hwmod data, USB3 will not in OMAP5 boards.
> > >
> > > While at that, also fix DTS data to pass reg property,
> > > otherwise driver won't probe.
> > >
> > > Signed-off-by: Benoit Cousson <benoit.cousson@linaro•org>
> > > Signed-off-by: Felipe Balbi <balbi@ti•com>
> > > ---
> > > arch/arm/boot/dts/omap5.dtsi | 3 +-
> > > arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 45 ++++++++++++++++++++++++++++++
> > > 2 files changed, 47 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> > > index 5c99f19..4e41409 100644
> > > --- a/arch/arm/boot/dts/omap5.dtsi
> > > +++ b/arch/arm/boot/dts/omap5.dtsi
> > > @@ -652,10 +652,11 @@
> > > };
> > > };
> > >
> > > - ocp2scp {
> > > + ocp2scp at 4a080000 {
> >
> > While at that, can we also name it ocp2scp1 since we have 3 instances of
> > ocp2scp and it'll conflict when we want to add it for SATA and PCIE.
Hmm the differentiatior is the name, so ocp2scp at 4a800000 should
be enough and actually follows the naming standars where the name
should describe the type. I guess it could be just ocp at 4a080000
or scp at 4a080000 but I think it translates both ways, so ocp2scp
is probably pretty good.
> Tony/Benoit, you want that in same patch or as a separate patch
> altogether ?
Please do the .dts changes in separate patches as they should
get merged separately for most part.
Regards,
Tony
next prev parent reply other threads:[~2013-07-16 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 15:33 [PATCH 0/4] Enable USB3 for OMAP5 Felipe Balbi
2013-07-15 15:33 ` [PATCH 1/4] arm: omap5: dts: fix reg property size Felipe Balbi
2013-07-15 15:33 ` [PATCH 2/4] arm: omap5: hwmod: add missing ocp2scp hwmod data Felipe Balbi
2013-07-15 15:43 ` Kishon Vijay Abraham I
2013-07-15 15:46 ` Felipe Balbi
2013-07-16 12:24 ` Tony Lindgren [this message]
2013-07-15 15:33 ` [PATCH 3/4] arm: omap5: dts: add palmas-usb node Felipe Balbi
2013-07-15 15:33 ` [PATCH 4/4] arm: omap2plus_defconfig: enable dwc3 and dependencies Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130716122432.GX7656@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox