From: gregkh@linuxfoundation•org (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 1/8] drivers: phy: add generic PHY framework
Date: Tue, 16 Jul 2013 23:29:44 -0700 [thread overview]
Message-ID: <20130717062944.GA24968@kroah.com> (raw)
In-Reply-To: <1372247257-30186-2-git-send-email-kishon@ti.com>
On Wed, Jun 26, 2013 at 05:17:29PM +0530, Kishon Vijay Abraham I wrote:
> +menuconfig GENERIC_PHY
> + tristate "PHY Subsystem"
> + help
> + Generic PHY support.
> +
> + This framework is designed to provide a generic interface for PHY
> + devices present in the kernel. This layer will have the generic
> + API by which phy drivers can create PHY using the phy framework and
> + phy users can obtain reference to the PHY.
Shouldn't this be something that other drivers select? How will anyone
know if they need this or not?
> --- /dev/null
> +++ b/drivers/phy/phy-core.c
> @@ -0,0 +1,544 @@
> +/*
> + * phy-core.c -- Generic Phy framework.
> + *
> + * Copyright (C) 2013 Texas Instruments
> + *
> + * Author: Kishon Vijay Abraham I <kishon@ti•com>
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
You really mean "any later version" (I have to ask)?
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
Are these two paragraphs needed? This isn't a "program", and they got a
copy of the GPL already with the kernel.
> +static struct class *phy_class;
Why do you need a class?
When modifying/adding new sysfs stuff, you need a Documentation/ABI/
entry as well.
thanks,
greg k-h
next prev parent reply other threads:[~2013-07-17 6:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 11:47 [PATCH v9 0/8] Generic PHY Framework Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 1/8] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
2013-06-26 12:10 ` Felipe Balbi
2013-07-17 6:29 ` Greg KH [this message]
2013-07-17 9:32 ` Kishon Vijay Abraham I
2013-07-17 17:25 ` Greg KH
2013-07-18 6:03 ` Kishon Vijay Abraham I
2013-07-18 6:24 ` Greg KH
2013-07-18 6:27 ` Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 2/8] usb: phy: omap-usb2: use the new " Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 3/8] usb: phy: twl4030: " Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 4/8] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 5/8] ARM: dts: omap: update usb_otg_hs data Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 6/8] usb: musb: omap2430: use the new generic PHY framework Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 7/8] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-06-26 11:47 ` [PATCH v9 8/8] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops Kishon Vijay Abraham I
2013-07-03 9:32 ` [PATCH v9 0/8] Generic PHY Framework Patel, Satish
2013-07-03 10:05 ` Kishon Vijay Abraham I
2013-07-03 13:20 ` Felipe Balbi
2013-07-04 5:17 ` Kishon Vijay Abraham I
2013-07-04 9:21 ` Patel, Satish
2013-07-04 9:55 ` Kishon Vijay Abraham I
2013-07-04 9:58 ` Patel, Satish
2013-07-04 10:12 ` Felipe Balbi
2013-07-04 10:45 ` Patel, Satish
2013-07-08 11:24 ` Patel, Satish
2013-07-08 12:17 ` Kishon Vijay Abraham I
2013-07-09 2:23 ` Patel, Satish
2013-07-09 11:44 ` Felipe Balbi
2013-07-09 12:33 ` Patel, Satish
2013-07-09 17:34 ` Felipe Balbi
2013-07-30 6:25 ` Rahul Sharma
2013-07-08 13:26 ` Felipe Balbi
[not found] <000d01ce73af$62a95a60$27fc0f20$@samsung.com>
2013-06-28 5:15 ` [PATCH v9 1/8] drivers: phy: add generic PHY framework Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717062944.GA24968@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox