From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/5] ARM: bcm4760: Add stub clock driver
Date: Sun, 21 Jul 2013 10:16:48 +0200 [thread overview]
Message-ID: <201307211016.49274.arnd@arndb.de> (raw)
In-Reply-To: <20130721002714.459727324@gmail.com>
On Sunday 21 July 2013, Domenico Andreoli wrote:
> +#include <linux/clk-provider.h>
> +#include <linux/clkdev.h>
> +#include <linux/clk/bcm4760.h>
> +
> +void __init bcm4760_init_clocks(void)
> +{
> + struct clk *clk;
> +
> + clk = clk_register_fixed_rate(NULL, "pclk", NULL, CLK_IS_ROOT, 78000000);
> + if (IS_ERR(clk))
> + pr_err("pclk not registered\n");
> +
> + if (clk_register_clkdev(clk, NULL, "c0000.uart0"))
> + pr_err("uart0 clk alias not registered\n");
> + if (clk_register_clkdev(clk, NULL, "c1000.uart1"))
> + pr_err("uart1 clk alias not registered\n");
> + if (clk_register_clkdev(clk, NULL, "b2000.uart2"))
> + pr_err("uart2 clk alias not registered\n");
> +}
Since these are all fixed-rate clocks, I think what you should do here is to
put them into the device tree as compatible="fixed-clock" and remove the code
here.
Arnd
next prev parent reply other threads:[~2013-07-21 8:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 0:23 [PATCH 0/5] ARM: Broadcom BCM4760 support Domenico Andreoli
2013-07-21 0:23 ` [PATCH 1/5] ARM: bcm4760: Add platform infrastructure Domenico Andreoli
2013-07-21 8:09 ` Arnd Bergmann
2013-07-21 10:29 ` Domenico Andreoli
2013-07-21 12:00 ` Arnd Bergmann
2013-07-22 23:52 ` Domenico Andreoli
2013-07-21 23:42 ` Domenico Andreoli
2013-07-21 0:23 ` [PATCH 2/5] ARM: bcm4760: Add system timer Domenico Andreoli
2013-07-21 8:14 ` Arnd Bergmann
2013-07-22 23:44 ` Domenico Andreoli
2013-07-21 0:23 ` [PATCH 3/5] ARM: bcm4760: Add ripple counter Domenico Andreoli
2013-07-21 0:23 ` [PATCH 4/5] ARM: bcm4760: Add stub clock driver Domenico Andreoli
2013-07-21 8:16 ` Arnd Bergmann [this message]
2013-07-21 0:23 ` [PATCH 5/5] ARM: bcm4760: Add restart hook Domenico Andreoli
2013-07-21 8:20 ` Arnd Bergmann
2013-07-22 21:14 ` Domenico Andreoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201307211016.49274.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox