From: olof@lixom•net (Olof Johansson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mmc: dw_mmc-exynos: Common bindings for dw-mshc timing
Date: Tue, 13 Aug 2013 22:29:40 -0700 [thread overview]
Message-ID: <20130814052940.GC16635@quad.lixom.net> (raw)
In-Reply-To: <52096C75.1030305@wwwdotorg.org>
On Mon, Aug 12, 2013 at 05:15:01PM -0600, Stephen Warren wrote:
> On 08/08/2013 04:55 PM, dinguyen at altera.com wrote:
> > From: Dinh Nguyen <dinguyen@altera•com>
> >
> > Remove the "samsung" in "samsung,dw-mshc-ciu-div", "samsung,dw-mshc-sdr-timing",
> > and "samsung,dw-mshc-ddr-timing". These characteristics are not applicable to
> > just Samsung platforms, but to any platform that uses the Synopsis SD/MMC IP.
>
> But the properties aren't globally standard; they apply specifically
> anywhere that this particular Synopsis IP is present. As such, I think
> at least a "synopsis," prefix is warranted.
A prefix is only really needed when a vendor is making a vendor-specific
extension on a shared binding. Since the whole binding is
synopsis-specific, I don't think there's need for a prefix here.
> And the driver should probably support both the old and new property
> names for backwards-compatibility?
Yes, that sounds appropriate if the binding is considered stable and
otherwise good.
The alternative is to have everybody just use the samsung,*
properties. There's nothing wrong with that per se, besides the fact
that if it had been caught when creating the binding, there should have
been no prefix and the properties should have been common.
-Olof
next prev parent reply other threads:[~2013-08-14 5:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 22:55 [PATCH] mmc: dw_mmc-exynos: Common bindings for dw-mshc timing dinguyen at altera.com
2013-08-09 2:54 ` Jaehoon Chung
2013-08-09 12:36 ` Seungwon Jeon
2013-08-09 14:54 ` Dinh Nguyen
2013-08-12 10:36 ` Seungwon Jeon
2013-08-09 14:49 ` Dinh Nguyen
2013-08-12 23:15 ` Stephen Warren
2013-08-14 5:29 ` Olof Johansson [this message]
2013-08-14 16:09 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814052940.GC16635@quad.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox