From: olof@lixom•net (Olof Johansson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 08/11] ARM: hi3xxx: add smp support
Date: Wed, 28 Aug 2013 10:19:07 -0700 [thread overview]
Message-ID: <20130828171907.GD8607@quad.lixom.net> (raw)
In-Reply-To: <CAMj5BkjJXeYd4Gh2+DKiJo60ftTSf0vnAiApH86+-zdsoVqXog@mail.gmail.com>
On Wed, Aug 28, 2013 at 07:53:03PM +0800, zhangfei gao wrote:
> Thanks Olof, will update with your comments.
>
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> >> index 3be60c8..4cc5c57 100644
> >> --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> >> +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
> >> @@ -8,3 +8,50 @@ Required root node properties:
> >> Hi4511 Board
> >> Required root node properties:
> >> - compatible = "hisilicon,hi3620-hi4511";
> >> +
> >> +
> >> +Hisilicon sctrl resiter
> >
> > Resiter seems like odd naming here.
> >
> >> +
> >> +Required properties:
> >> +- compatible : "hisilicon,sctrl"
> >> +- reg : Address and size of sysctrl.
> >
> > sysctrl or sctrl? sysctrl isn't really too long, might as well use that.
> >
> >> +
> >> +Optional properties:
> >> +- smp_reg : offset in sysctrl for notifying slave cpu booting
> >> + cpu 1, reg;
> >> + cpu 2, reg + 0x4;
> >> + cpu 3, reg + 0x8;
> >> + If reg value is not zero, cpun exit wfi and go
> >> +- resume_reg : offset in sysctrl for notifying cpu0 when resume
> >> +- reset_reg : offset in sysctrl for system reset
> >
> > Underscores are usually not used in properties, you use dashes instead.
> >
> > Anyway, I suggest defining those as the different cells in a regular 'reg'
> > property instead.
>
> Will update with
>
> Required properties:
> - compatible : "hisilicon,sysctrl"
> - reg : Register address and size
>
> Optional properties:
> - smp-off : offset in sysctrl for notifying slave cpu booting
> cpu 1, reg;
> cpu 2, reg + 0x4;
> cpu 3, reg + 0x8;
> If reg value is not zero, cpun exit wfi and go
> - resume-off : offset in sysctrl for notifying cpu0 when resume
> - reboot-off : offset in sysctrl for system reboot
Unabbreviated "offset" would be better than "off" here.
Do you even need this in the device tree? Do you have different implementations
of this IP that has the same programming model but just with a couple of
different offsets?
-Olof
next prev parent reply other threads:[~2013-08-28 17:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 2:31 [PATCH v7 00/11] Enable Hisilicon Hi3620 SoC Haojian Zhuang
2013-08-20 2:31 ` [PATCH v7 01/11] ARM: debug: support debug ll on hisilicon soc Haojian Zhuang
2013-08-20 2:31 ` [PATCH v7 02/11] clk: hi3xxx: add clock support Haojian Zhuang
2013-08-21 21:29 ` Mike Turquette
2013-08-24 4:13 ` Haojian Zhuang
2013-08-20 2:31 ` [PATCH v7 03/11] clk: gate: add CLK_GATE_SEPERATED_REG flag Haojian Zhuang
2013-08-21 21:18 ` Mike Turquette
2013-08-20 2:31 ` [PATCH v7 04/11] ARM: hi3xxx: add board support with device tree Haojian Zhuang
2013-08-20 2:31 ` [PATCH v7 05/11] ARM: dts: enable hi4511 " Haojian Zhuang
2013-08-22 18:07 ` Kevin Hilman
2013-08-22 18:50 ` Stephen Warren
2013-08-24 3:52 ` Haojian Zhuang
2013-08-26 16:48 ` Stephen Warren
2013-08-28 2:17 ` Haojian Zhuang
2013-08-28 14:20 ` Stephen Warren
2013-08-28 15:15 ` Haojian Zhuang
2013-08-28 15:45 ` Stephen Warren
2013-08-24 3:59 ` Haojian Zhuang
2013-08-20 2:31 ` [PATCH v7 06/11] ARM: config: enable hi3xxx in multi_v7_defconfig Haojian Zhuang
2013-08-20 2:31 ` [PATCH v7 07/11] ARM: config: add defconfig for Hi3xxx Haojian Zhuang
2013-08-20 2:31 ` [PATCH v7 08/11] ARM: hi3xxx: add smp support Haojian Zhuang
2013-08-28 2:12 ` Olof Johansson
2013-08-28 11:53 ` zhangfei gao
2013-08-28 17:19 ` Olof Johansson [this message]
2013-08-29 1:54 ` zhangfei
2013-08-20 2:31 ` [PATCH v7 09/11] ARM: hi3xxx: add hotplug support Haojian Zhuang
2013-08-28 2:21 ` Olof Johansson
2013-08-28 11:45 ` zhangfei gao
2013-08-20 2:31 ` [PATCH v7 10/11] ARM: hi3xxx: add clk-hi3716 Haojian Zhuang
2013-08-21 21:43 ` Mike Turquette
2013-08-22 1:19 ` zhangfei gao
2013-08-22 5:59 ` Mike Turquette
2013-08-22 7:50 ` Haojian Zhuang
2013-08-22 8:16 ` Mike Turquette
2013-08-20 2:31 ` [PATCH v7 11/11] ARM: hi3xxx: support hi3716-dkb board Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828171907.GD8607@quad.lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox