From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/5] clk: tegra: Add periph regs bank X
Date: Thu, 10 Oct 2013 12:43:07 +0200 [thread overview]
Message-ID: <20131010104306.GB6735@ulmo.nvidia.com> (raw)
In-Reply-To: <1380878014-22088-3-git-send-email-pdeschrijver@nvidia.com>
On Fri, Oct 04, 2013 at 12:12:41PM +0300, Peter De Schrijver wrote:
> Tegra124 has an extra bank of peripheral clock registers. Add it to the
> generic peripheral clock code.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia•com>
> ---
> drivers/clk/tegra/clk.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk.c b/drivers/clk/tegra/clk.c
> index c8c84ce..0240dc3 100644
> --- a/drivers/clk/tegra/clk.c
> +++ b/drivers/clk/tegra/clk.c
> @@ -57,6 +57,8 @@
> #define RST_DEVICES_CLR_V 0x434
> #define RST_DEVICES_SET_W 0x438
> #define RST_DEVICES_CLR_W 0x43c
> +#define RST_DEVICES_SET_X 0x290
> +#define RST_DEVICES_CLR_X 0x294
Perhaps sort these numerically rather than alphabetically? Also I don't
see where the CLK_OUT_ENB_X, CLK_OUT_ENB_{SET,CLR}_X or RST_DEVICES_X
registers are defined. Perhaps they were part of some other patch or a
series that this depends on?
>
> /* Global data of Tegra CPU CAR ops */
> static struct tegra_cpu_car_ops dummy_car_ops;
> @@ -109,6 +111,14 @@ static struct tegra_clk_periph_regs periph_regs[] = {
> .rst_set_reg = RST_DEVICES_SET_W,
> .rst_clr_reg = RST_DEVICES_CLR_W,
> },
> + [5] = {
> + .enb_reg = CLK_OUT_ENB_X,
> + .enb_set_reg = CLK_OUT_ENB_SET_X,
> + .enb_clr_reg = CLK_OUT_ENB_CLR_X,
> + .rst_reg = RST_DEVICES_X,
> + .rst_set_reg = RST_DEVICES_SET_X,
> + .rst_clr_reg = RST_DEVICES_CLR_X,
> + },
> };
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131010/6e018d46/attachment.sig>
next prev parent reply other threads:[~2013-10-10 10:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 9:12 [PATCH 0/5] Tegra124 clock support Peter De Schrijver
2013-10-04 9:12 ` [PATCH 1/5] clk: tegra: Add support for PLLSS Peter De Schrijver
2013-10-10 10:39 ` Thierry Reding
2013-10-10 10:59 ` Peter De Schrijver
2013-10-14 15:03 ` Peter De Schrijver
2013-10-04 9:12 ` [PATCH 2/5] clk: tegra: Add periph regs bank X Peter De Schrijver
2013-10-10 10:43 ` Thierry Reding [this message]
2013-10-10 11:00 ` Peter De Schrijver
2013-10-04 9:12 ` [PATCH 3/5] clk: tegra124: Add common clk IDs to clk-id.h Peter De Schrijver
2013-10-08 22:29 ` Stephen Warren
2013-10-04 9:12 ` [PATCH 4/5] clk: tegra124: Add new peripheral clocks Peter De Schrijver
2013-10-08 22:31 ` Stephen Warren
2013-10-09 8:11 ` Peter De Schrijver
2013-10-09 16:00 ` Stephen Warren
2013-10-10 8:51 ` Peter De Schrijver
2013-10-04 9:12 ` [PATCH 5/5] clk: tegra124: Add support for Tegra124 clocks Peter De Schrijver
2013-10-08 22:31 ` [PATCH 0/5] Tegra124 clock support Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131010104306.GB6735@ulmo.nvidia.com \
--to=thierry.reding@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox