From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v10 2/7] ARM: hi3xxx: add board support with device tree
Date: Tue, 15 Oct 2013 20:06:38 +0200 [thread overview]
Message-ID: <201310152006.38824.arnd@arndb.de> (raw)
In-Reply-To: <CAD6h2NR6umVpgYM2t2pwrwP8-Jk-e3Kfng-7oymPJ44cNmuk-w@mail.gmail.com>
On Tuesday 15 October 2013, Haojian Zhuang wrote:
> On 15 October 2013 21:00, Arnd Bergmann <arnd@arndb•de> wrote:
> > On Tuesday 15 October 2013, Haojian Zhuang wrote:
> >>
> >> Add board support with device tree for Hisilicon Hi3620 SoC platform.
> >>
> >> Changelog:
> >> v10:
> >> 1. Add .map_io() & debug_ll_io_init() back. Since debug_ll_io_init() is
> >> only called if .map_io() isn't assigned. Use .map_io() to setup static
> >> IO mapping that is used in clock driver.
> >>
> >
> > This seems like a step in the wrong direction. Why would you want to use
> > a static I/O mapping in the clock driver?
> >
>
> Because Stephen & Kevin asked me to use unit address in DTS file. They
> also require me to use reg property to present real hardware address
> in DTS file.
Ah, so it's just an optimization, not required to make the clock driver
work, I misread that. Can you add a comment near the hi3620_io_desc
definition and verify that it still works without it?
I would also recommend to extend that static mapping to the entire
0xfc800000-0xfcbfffff range, or whatever you can use to get the most
I/O devices with a small number of TLB entries.
Arnd
next prev parent reply other threads:[~2013-10-15 18:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 9:16 [PATCH v10 0/7] enable hi3xxx SoC Haojian Zhuang
2013-10-15 9:16 ` [PATCH v10 1/7] clk: hi3xxx: add clock support Haojian Zhuang
2013-10-30 19:44 ` Mike Turquette
2013-10-15 9:16 ` [PATCH v10 2/7] ARM: hi3xxx: add board support with device tree Haojian Zhuang
2013-10-15 13:00 ` Arnd Bergmann
2013-10-15 13:12 ` Haojian Zhuang
2013-10-15 18:06 ` Arnd Bergmann [this message]
2013-10-16 1:08 ` Haojian Zhuang
2013-10-16 1:31 ` Haojian Zhuang
2013-10-16 7:27 ` Arnd Bergmann
2013-10-15 9:16 ` [PATCH v10 3/7] ARM: dts: enable hi4511 " Haojian Zhuang
2013-10-15 18:18 ` Arnd Bergmann
2013-10-16 2:09 ` Haojian Zhuang
2013-10-16 7:10 ` Arnd Bergmann
2013-10-16 7:26 ` Linus Walleij
2013-10-15 9:16 ` [PATCH v10 4/7] ARM: config: enable hi3xxx in multi_v7_defconfig Haojian Zhuang
2013-10-15 9:16 ` [PATCH v10 5/7] ARM: config: add defconfig for Hi3xxx Haojian Zhuang
2013-10-15 9:16 ` [PATCH v10 6/7] ARM: hi3xxx: add smp support Haojian Zhuang
2013-10-15 9:16 ` [PATCH v10 7/7] ARM: hi3xxx: add hotplug support Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201310152006.38824.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox