From: giometti@enneenne•com (Rodolfo Giometti)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH v2] ARM: at91: add support for Cosino board series by HCE Engineering
Date: Thu, 14 Nov 2013 19:50:02 +0100 [thread overview]
Message-ID: <20131114185002.GM10964@enneenne.com> (raw)
In-Reply-To: <20131114162810.GJ28304@ns203013.ovh.net>
On Thu, Nov 14, 2013 at 05:28:10PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 18:34 Wed 13 Nov , Nicolas Ferre wrote:
> > From: Rodolfo Giometti <giometti@linux•it>
> >
> > This patch adds the Cosino at91sam9g35 based CPU module and the
> > Cosino Mega 2560 extension board.
> >
> > Web site: http://www.cosino.it
> >
> > Signed-off-by: Rodolfo Giometti <giometti@linux•it>
> > [nicolas.ferre at atmel.com: adapted to newer kernel, modified commit message]
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
> > ---
> > Rodolfo,
> >
> > Can you please review this adaptation of your previous patch to newer kernel.
> > I hope to integrate your board in upcoming 3.14.
> >
> > You will see that I addressed the remarks by Jean-Christophe and Russell (about
> > commit message). Please tell me if it is good on your side.
> >
> > Ciao,
> >
> >
> > arch/arm/boot/dts/Makefile | 1 +
> > arch/arm/boot/dts/at91-cosino.dtsi | 122 +++++++++++++++++++++++++++++
> > arch/arm/boot/dts/at91-cosino_mega2560.dts | 85 ++++++++++++++++++++
> > 3 files changed, 208 insertions(+)
> > create mode 100644 arch/arm/boot/dts/at91-cosino.dtsi
> > create mode 100644 arch/arm/boot/dts/at91-cosino_mega2560.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index d57c1a6..772a30e 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_AT91) += pm9g45.dtb
> > dtb-$(CONFIG_ARCH_AT91) += at91sam9n12ek.dtb
> > # sam9x5
> > dtb-$(CONFIG_ARCH_AT91) += at91-ariag25.dtb
> > +dtb-$(CONFIG_ARCH_AT91) += at91-cosino_mega2560.dtb
> > dtb-$(CONFIG_ARCH_AT91) += at91sam9g15ek.dtb
> > dtb-$(CONFIG_ARCH_AT91) += at91sam9g25ek.dtb
> > dtb-$(CONFIG_ARCH_AT91) += at91sam9g35ek.dtb
> > diff --git a/arch/arm/boot/dts/at91-cosino.dtsi b/arch/arm/boot/dts/at91-cosino.dtsi
> > new file mode 100644
> > index 0000000..53f2b01
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/at91-cosino.dtsi
> > @@ -0,0 +1,122 @@
> > +/*
> > + * at91-cosino.dtsi - Device Tree file for Cosino core module
> > + *
> > + * Copyright (C) 2013 - Rodolfo Giometti <giometti@linux•it>
> > + * HCE Engineering
> > + *
> > + * Derived from at91sam9x5ek.dtsi by:
> > + * Copyright (C) 2012 Atmel,
> > + * 2012 Nicolas Ferre <nicolas.ferre@atmel•com>
> > + *
> > + * Licensed under GPLv2 or later.
> > + */
> > +
> > +#include "at91sam9g35.dtsi"
> > +
> > +/ {
> > + model = "HCE Cosino core module";
> > + compatible = "hce,cosino", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";
> is this really sam9xek compatible?
Well, the board is derived from ATMEL dev board... maybe I can remove
these lines... :-/
> > +
> > + chosen {
> > + bootargs = "console=ttyS0,115200 root=/dev/mmcblk0p2 rw rootfstype=ext3 rootwait";
> > + };
> > +
> ...
> > +/ {
> > + model = "HCE Cosino Mega 2560";
> > + compatible = "hce,cosino_mega2560", "atmel,at91sam9x5ek", "atmel,at91sam9x5", "atmel,at91sam9";
> ditto
> > +
> > + ahb {
> > + apb {
> > + macb0: ethernet at f802c000 {
> > + phy-mode = "rmii";
> > + status = "okay";
> > + };
> > +
> > + adc0: adc at f804c000 {
> > + atmel,adc-clock-rate = <1000000>;
> > + atmel,adc-ts-wires = <4>;
> > + atmel,adc-ts-pressure-threshold = <10000>;
> > + status = "okay";
> > + };
> > +
> > +
> > + tsadcc: tsadcc at f804c000 {
> > + status = "okay";
> > + };
> > +
> > + rtc at fffffeb0 {
> > + status = "okay";
> > + };
> > +
> > + usart1: serial at f8020000 {
> > + status = "okay";
> tab no space
Fixed
> > + };
> > +
> > + usart2: serial at f8024000 {
> > + status = "okay";
> tab no space
Fixed
> > + };
> > +
> > + usb2: gadget at f803c000 {
> > + atmel,vbus-gpio = <&pioB 16 GPIO_ACTIVE_HIGH>;
> > + status = "okay";
> > + };
> > +
> > + usb0: ohci at 00600000 {
> > + status = "okay";
> > + num-ports = <3>;
> > + atmel,vbus-gpio = <0 /* &pioD 18 GPIO_ACTIVE_LOW *//* Activate to have access to port A */
> do we really need the comment code?
Ok, I dropped second comment...
> > + &pioD 19 GPIO_ACTIVE_LOW
> > + &pioD 20 GPIO_ACTIVE_LOW
> > + >;
> > + };
> > +
> Best Regards,
> J.
Attached the new patch version.
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti at enneenne.com
Linux Device Driver giometti at linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-arm-mach-at91-add-support-for-Cosino-board-series-by.patch
Type: text/x-diff
Size: 5939 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131114/f087a269/attachment-0001.bin>
next prev parent reply other threads:[~2013-11-14 18:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 16:19 [PATCH 1/1] arm mach-at91: add support for Cosino board series by HCE Engineering Rodolfo Giometti
2013-11-06 16:21 ` Russell King - ARM Linux
2013-11-06 16:25 ` Rodolfo Giometti
2013-11-07 6:06 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-13 17:34 ` [RFC PATCH v2] ARM: at91: " Nicolas Ferre
2013-11-13 17:46 ` Rodolfo Giometti
2013-11-14 8:56 ` Nicolas Ferre
2013-11-14 10:20 ` Rodolfo Giometti
2013-11-14 16:28 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-14 18:50 ` Rodolfo Giometti [this message]
2013-11-15 13:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-20 18:18 ` Rodolfo Giometti
2013-11-20 18:50 ` Jean-Christophe PLAGNIOL-VILLARD
2013-11-21 8:24 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114185002.GM10964@enneenne.com \
--to=giometti@enneenne$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox