From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RESEND v5 1/2] PWM: PXA: add device tree support to PWM driver
Date: Wed, 4 Dec 2013 10:03:13 +0100 [thread overview]
Message-ID: <20131204090312.GK19943@ulmo.nvidia.com> (raw)
In-Reply-To: <529E8193.1040606@linaro.org>
On Wed, Dec 04, 2013 at 09:12:51AM +0800, Haojian Zhuang wrote:
>
> On 12/04/2013 02:45 AM, Mike Dunn wrote:
> >On 12/03/2013 02:17 AM, Thierry Reding wrote:
> >>On Sat, Sep 21, 2013 at 12:19:33PM -0700, Mike Dunn wrote:
> >>>This patch adds device tree support to the PXA's PWM driver. Nothing
> >>>needs to be extracted from the device tree node by the PWM device.
> >>>Client devices need only specify the period; the per-chip index is
> >>>implicitly zero because one device node must be present for each PWM
> >>>output in use. This approach is more convenient due to the wide
> >>>variability in the number of PWM channels present across the various PXA
> >>>variants, and is made possible by the fact that the register sets for
> >>>each PWM channel are segregated from each other. An of_xlate() method
> >>>is added to parse this single-cell node. The existing ID table is
> >>>reused for the match table data.
> >>>
> >>>Tested on a Palm Treo 680 (both platform data and DT cases).
> >>>
> >>>Signed-off-by: Mike Dunn <mikedunn@newsguy•com>
> >>>---
> >>> Documentation/devicetree/bindings/pwm/pxa-pwm.txt | 30 +++++++++++++
> >>> drivers/pwm/pwm-pxa.c | 52 ++++++++++++++++++++++-
> >>> 2 files changed, 81 insertions(+), 1 deletion(-)
> >>> create mode 100644 Documentation/devicetree/bindings/pwm/pxa-pwm.txt
> >>Hi Mike,
> >>
> >>It looks like this fell through the cracks. Is this patch still the
> >>latest one you have? Should it still be applied?
> >>
> >>Thierry
> >>
> >Hi Thierry,
> >
> >Funny I should hear from you about this today.... I just turned my attention
> >back to this today and noticed that it never made it into your for-next branch.
> > Yes, it is the latest. If the patch still applies cleanly, please feel free.
> >Otherwise, I'd be glad to rework it against something more recent.
> >
> >Also, we never got any ACKs for patch 2/2, which just adds the nodes to
> >arch/arm/boot/dts/pxa27x.dtsi
> >Any advice on whom to nudge?
> >
> >Thanks much!
> >Mike
> >
>
> It's fine to me.
>
> Acked-by: Haojian Zhuang <haojian.zhuang@linaro•org>
I think it's customary to take DTS file updates through the architecture
trees, so I think it'd be better if you took patch 2/2. There aren't any
dependencies between both patches either.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131204/be4e15f2/attachment-0001.sig>
next prev parent reply other threads:[~2013-12-04 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 19:19 [PATCH RESEND v5 0/2] PWM: PXA: add device tree support to PWM driver Mike Dunn
2013-09-21 19:19 ` [PATCH RESEND v5 1/2] " Mike Dunn
2013-10-08 13:12 ` Thierry Reding
2013-10-10 16:58 ` Mike Dunn
2013-12-03 10:17 ` Thierry Reding
2013-12-03 18:45 ` Mike Dunn
2013-12-04 1:12 ` Haojian Zhuang
2013-12-04 9:03 ` Thierry Reding [this message]
2013-12-04 9:17 ` Haojian Zhuang
2013-12-04 9:21 ` Thierry Reding
2013-12-04 18:21 ` Mike Dunn
2013-09-21 19:19 ` [PATCH RESEND v5 2/2] PXA: add PWM nodes to pxa27x.dtsi Mike Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204090312.GK19943@ulmo.nvidia.com \
--to=thierry.reding@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox