From: bjorn.andersson@sonymobile•com (Bjorn Andersson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 2/3] pinctrl: Add msm8x74 configuration
Date: Tue, 10 Dec 2013 00:41:41 -0800 [thread overview]
Message-ID: <20131210084140.GF11990@sonymobile.com> (raw)
In-Reply-To: <52A24E08.706@codeaurora.org>
On Fri 06 Dec 14:22 PST 2013, Stephen Boyd wrote:
> > +config PINCTRL_MSM8X74
> > + bool "Qualcomm 8x74 pin controller driver"
> > + select PINCTRL_MSM
>
> No help?
>
I could write something up, although I guess someone will add a
select PINCTRL_MSM8X74 in the mach-msm Kconfig and then we're done
with it.
> > + .ctl_reg = 0x1000 + 0x10 * id , \
>
> Weird trailing space here.
>
Oops.
> Also, do we ever plan to have anything more than the gpio pins and the
> sdc pins? It seems like we spend a lot of space describing exactly the
> same thing in these structs for each of the 146 gpio pins when we could
> just know that range 0 to 146 is gpio pins and have different code for
> that part vs the 6 or something sd pins.
>
We have to have a pingroup list, so I did look at having that list
referencing a common object with the gpio/sdc specific data.
But just having it in one large blob is the way that other pinctrl
drivers does it and hence a common problem to pinctrl and multi-platform
arm support.
I have not seen any code in the open referencing the other pins, so I
left them out for now.
> > +
> > +static struct of_device_id msm8x74_pinctrl_of_match[] = {
>
> const?
>
Of course.
> >
> > +
> > +static int __init msm8x74_pinctrl_init(void)
> > +{
> > + return platform_driver_register(&msm8x74_pinctrl_driver);
> > +}
> > +arch_initcall(msm8x74_pinctrl_init);
> > +
> > +static void __exit msm8x74_pinctrl_exit(void)
> > +{
> > + platform_driver_unregister(&msm8x74_pinctrl_driver);
> > +}
> > +module_exit(msm8x74_pinctrl_exit);
>
> Why not module_platform_driver()? I thought pinctrl supported deferred
> probing?
>
As this pinctrl/gpiochip/interrupt-controller is a fairly central part
of the system there's plenty of things that would just end up being deferred.
Most other pinctrl driver does arch_initcall or core_initcall, so I followed
suit and brought it in early.
Regards,
Bjorn
next prev parent reply other threads:[~2013-12-10 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386295805-13708-1-git-send-email-bjorn.andersson@sonymobile.com>
2013-12-06 13:56 ` [PATCH v2 0/3] pinctrl: Qualcomm 8x74 pinctrl driver Linus Walleij
[not found] ` <1386295805-13708-3-git-send-email-bjorn.andersson@sonymobile.com>
2013-12-06 22:22 ` [PATCH v2 2/3] pinctrl: Add msm8x74 configuration Stephen Boyd
2013-12-09 8:18 ` Linus Walleij
2013-12-09 21:37 ` Stephen Boyd
2013-12-10 8:27 ` Bjorn Andersson
2013-12-10 8:41 ` Bjorn Andersson [this message]
2013-12-11 1:49 ` Stephen Boyd
2013-12-12 19:15 ` Linus Walleij
2013-12-12 21:16 ` Linus Walleij
2013-12-13 4:24 ` Bjorn Andersson
2013-12-12 21:22 ` Linus Walleij
[not found] ` <1386295805-13708-2-git-send-email-bjorn.andersson@sonymobile.com>
2013-12-06 21:40 ` [PATCH v2 1/3] pinctrl: Add Qualcomm TLMM driver Stephen Boyd
2013-12-10 8:10 ` Bjorn Andersson
2013-12-11 1:42 ` Stephen Boyd
2013-12-12 19:09 ` Linus Walleij
2014-11-25 19:55 ` Timur Tabi
2014-11-26 17:41 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210084140.GF11990@sonymobile.com \
--to=bjorn.andersson@sonymobile$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox