From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: Nomadik clk not MULTI_V5 friendly
Date: Mon, 20 Jan 2014 23:01:18 +0100 [thread overview]
Message-ID: <20140120220118.GN15169@lunn.ch> (raw)
Hi Linus
drivers/clk/clk-nomadik.c:
static int __init nomadik_src_clk_init_debugfs(void)
{
src_pcksr0_boot = readl(src_base + SRC_PCKSR0);
src_pcksr1_boot = readl(src_base + SRC_PCKSR1);
debugfs_create_file("nomadik-src-clk", S_IFREG | S_IRUGO,
NULL, NULL, &nomadik_src_clk_debugfs_ops);
return 0;
}
module_init(nomadik_src_clk_init_debugfs);
It does not check if it is actually running on a Nomadik, so when this
module_init() is executed on kirkwood as part of a MULTI_V5 kernel,
bad things happen. Please could you add the necessary check.
Thanks
Andrew
next reply other threads:[~2014-01-20 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 22:01 Andrew Lunn [this message]
2014-01-21 8:07 ` Nomadik clk not MULTI_V5 friendly Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120220118.GN15169@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox