From: peterz@infradead•org (Peter Zijlstra)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop
Date: Thu, 30 Jan 2014 19:06:59 +0100 [thread overview]
Message-ID: <20140130180659.GI5002@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <52EA8BD4.6020803@linaro.org>
On Thu, Jan 30, 2014 at 06:28:52PM +0100, Daniel Lezcano wrote:
> Ok, I think the mess is coming from 'default_idle' which does not re-enable
> the local_irq but used from different places like amd_e400_idle and
> apm_cpu_idle.
>
> void default_idle(void)
> {
> trace_cpu_idle_rcuidle(1, smp_processor_id());
> safe_halt();
> trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> }
>
> Considering the system configured without cpuidle because this one *always*
> enable the local irq, we have the different cases:
>
> x86_idle = default_idle();
> ==> local_irq_enable is missing
>
safe_halt() is "sti; hlt" and so very much does the irq_enable.
next prev parent reply other threads:[~2014-01-30 18:06 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 17:45 [PATCH v2 0/6] setting the table for integration of cpuidle with the scheduler Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop Nicolas Pitre
2014-01-29 20:31 ` Nicolas Pitre
2014-01-30 3:38 ` Preeti U Murthy
2014-01-30 5:28 ` Nicolas Pitre
2014-01-30 5:50 ` Preeti U Murthy
2014-01-30 13:44 ` Daniel Lezcano
2014-01-30 16:07 ` Nicolas Pitre
2014-01-30 17:28 ` Daniel Lezcano
2014-01-30 18:06 ` Peter Zijlstra [this message]
2014-01-30 19:24 ` Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 2/6] ARM: remove redundant cpuidle_idle_call() Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 3/6] PPC: " Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 4/6] SH: " Nicolas Pitre
2014-01-29 17:45 ` [PATCH v2 5/6] X86: " Nicolas Pitre
2014-01-29 19:02 ` Olof Johansson
2014-01-29 20:14 ` Nicolas Pitre
2014-01-30 9:24 ` Peter Zijlstra
2014-01-29 17:45 ` [PATCH v2 6/6] cpu/idle.c: move to sched/idle.c Nicolas Pitre
2014-01-30 15:25 ` Peter Zijlstra
2014-01-30 16:03 ` Nicolas Pitre
2014-01-30 16:27 ` Peter Zijlstra
2014-01-30 16:41 ` Joe Perches
2014-01-30 16:52 ` Peter Zijlstra
2014-02-06 14:09 ` Nicolas Pitre
2014-02-06 16:43 ` Peter Zijlstra
2014-02-07 11:09 ` Nicolas Pitre
2014-02-07 12:32 ` Peter Zijlstra
2014-01-30 9:28 ` [PATCH v2 0/6] setting the table for integration of cpuidle with the scheduler Peter Zijlstra
2014-01-30 13:31 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130180659.GI5002@laptop.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox