Subject: [PATCH] clk: respect the clock dependencies in of_clk_init

From: [email-masked] (Ezequiel Garcia)
Date: Fri, 7 Feb 2014 11:43:26 -0300

On Fri, Feb 07, 2014 at 09:24:30AM -0500, Jason Cooper wrote:
> On Fri, Feb 07, 2014 at 10:06:08AM -0300, Emilio L?pez wrote:
> 
> [snip a great explanation]
> 
> Guys, can I get some Tested-by's on this?
> 

In case someone missed Emilio's comment about it, I gave his oneliner
a test on A370 Reference Design. It worked just as well as Sebastian's.

Tested-by: Ezequiel Garcia <[email-masked]>

> > -----8<------
> > 
> > From ffdb49506e3ce92090c15e1f9b37f4d465097ac1 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Emilio=20L=C3=B3pez?= <[email-masked]>
> > Date: Thu, 6 Feb 2014 18:07:07 -0300
> > Subject: [PATCH] clk: mvebu: fix name dependency during registration time
> > 
> > Currently, mvebu_clk_gating_setup has a silly dependency on clock
> > registration order just to gather the parent clock name. This is
> > completely unnecesary, as it supports using an already provided name
> > via the clk_gating_soc_desc structs, and we can therefore solve this
> > issue with a 69+/- line patch. But, given that the parent name is
> > always "tclk" as default-hardcoded on mvebu_coreclk_setup(), we can
> > just default-hardcode it here too and get away with solving this
> > problem with a one-liner.
> > ---
> >  drivers/clk/mvebu/common.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/mvebu/common.c b/drivers/clk/mvebu/common.c
> > index 25ceccf..6c63b43 100644
> > --- a/drivers/clk/mvebu/common.c
> > +++ b/drivers/clk/mvebu/common.c
> > @@ -121,7 +121,7 @@ void __init mvebu_clk_gating_setup(struct
> > device_node *np,
> >  	struct clk_gating_ctrl *ctrl;
> >  	struct clk *clk;
> >  	void __iomem *base;
> > -	const char *default_parent = NULL;
> > +	const char *default_parent = "tclk";
> >  	int n;
> > 
> >  	base = of_iomap(np, 0);
> > -- 
> > 1.8.5.3

-- 
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com