From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/6] arm64: Add ftrace support
Date: Mon, 10 Feb 2014 16:03:21 +0100 [thread overview]
Message-ID: <201402101603.21791.arnd@arndb.de> (raw)
In-Reply-To: <1391768336-5642-2-git-send-email-takahiro.akashi@linaro.org>
On Friday 07 February 2014, AKASHI Takahiro wrote:
> @@ -0,0 +1,23 @@
> +
> +#ifdef CONFIG_FUNCTION_TRACER
> +#define MCOUNT_ADDR ((unsigned long)_mcount)
> +#define MCOUNT_INSN_SIZE 4 /* sizeof mcount call */
> +
> +#ifndef __ASSEMBLY__
> +extern void _mcount(unsigned long);
> +#endif /* __ASSEMBLY__ */
> +#endif /* CONFIG_FUNCTION_TRACER */
We generally like to have as few #ifdef as possible, and I think the
#ifdef CONFIG_FUNCTION_TRACER here is not needed.
> +#endif /* __ASM_FTRACE_H */
> diff --git a/arch/arm64/kernel/Makefile b/arch/arm64/kernel/Makefile
> index 2d4554b..ca921fb 100644
> --- a/arch/arm64/kernel/Makefile
> +++ b/arch/arm64/kernel/Makefile
> @@ -5,6 +5,11 @@
> CPPFLAGS_vmlinux.lds := -DTEXT_OFFSET=$(TEXT_OFFSET)
> AFLAGS_head.o := -DTEXT_OFFSET=$(TEXT_OFFSET)
>
> +ifdef CONFIG_FUNCTION_TRACER
> +CFLAGS_REMOVE_ftrace.o = -pg
> +CFLAGS_REMOVE_insn.o = -pg
> +endif
Same here. It never hurts to have the CFLAGS_REMOVE_* statements here, since
you will not want to build these files for profiling.
> diff --git a/arch/arm64/kernel/arm64ksyms.c b/arch/arm64/kernel/arm64ksyms.c
> index 338b568..7f0512f 100644
> --- a/arch/arm64/kernel/arm64ksyms.c
> +++ b/arch/arm64/kernel/arm64ksyms.c
> @@ -56,3 +56,7 @@ EXPORT_SYMBOL(clear_bit);
> EXPORT_SYMBOL(test_and_clear_bit);
> EXPORT_SYMBOL(change_bit);
> EXPORT_SYMBOL(test_and_change_bit);
> +
> +#ifdef CONFIG_FUNCTION_TRACER
> +EXPORT_SYMBOL(_mcount);
> +#endif
This one is clearly needed of course.
> +/*
> + * Gcc with -pg will put the following code in the beginning of each function:
> + * mov x0, x30
> + * bl _mcount
> + * [function's body ...]
> + * "bl _mcount" may be replaced to "bl ftrace_caller" or NOP if dynamic
> + * ftrace is enabled.
Unrelated to your patch, I have run into problems with this on arm32, maybe
someone on Cc to this mail has an idea what to do about it:
If I build a large "randconfig" kernel or "allyesconfig", the kernel image
size exceeds 32MB, which means I can no longer link callers with a 26
bit signed immediate argument like the "bl _mcount" here. For any other
function calls, "gcc -mlong-calls" can be used to work around this, but
this particular instance is created by inserting assembly statements
into the output without considering the long-call options. Is there
a way to get the kernel to link anyway?
> +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
Here, again, you an remove the #ifdef by making the entire file built
only for CONFIG_FUNCTION_GRAPH_TRACER.
Arnd
next prev parent reply other threads:[~2014-02-10 15:03 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 7:08 [PATCH v2 0/6] arm64: Add ftrace support AKASHI Takahiro
2013-10-24 7:08 ` [PATCH v2 1/6] " AKASHI Takahiro
2013-10-24 7:08 ` [PATCH v2 2/6] arm64: ftrace: Add dynamic " AKASHI Takahiro
2013-10-24 7:08 ` [PATCH v2 3/6] arm64: ftrace: Add CALLER_ADDRx macros AKASHI Takahiro
2013-10-24 7:08 ` [PATCH v2 4/6] ftrace: Add arm64 support to recordmcount AKASHI Takahiro
2013-10-24 7:08 ` [PATCH v2 5/6] arm64: ftrace: Add system call tracepoint AKASHI Takahiro
2013-10-24 7:08 ` [PATCH v2 6/6] arm64: Add 'notrace' attribute to unwind_frame() for ftrace AKASHI Takahiro
2014-02-07 10:18 ` [PATCH v3 0/6] arm64: Add ftrace support AKASHI Takahiro
2014-02-07 10:18 ` [PATCH v3 1/6] " AKASHI Takahiro
2014-02-10 15:03 ` Arnd Bergmann [this message]
2014-02-10 15:19 ` Steven Rostedt
[not found] ` <CAB5YjtCr2KL_q1FF8kO_VKe+feg7f9qFRKtwf3xj2h0ENwuB5g@mail.gmail.com>
2014-02-12 11:03 ` Arnd Bergmann
2014-02-17 18:12 ` Will Deacon
2014-02-19 10:46 ` AKASHI Takahiro
2014-02-07 10:18 ` [PATCH v3 2/6] arm64: ftrace: Add dynamic " AKASHI Takahiro
2014-02-07 10:18 ` [PATCH v3 3/6] arm64: ftrace: Add CALLER_ADDRx macros AKASHI Takahiro
2014-02-07 10:18 ` [PATCH v3 4/6] ftrace: Add arm64 support to recordmcount AKASHI Takahiro
2014-02-07 10:18 ` [PATCH v3 5/6] arm64: ftrace: Add system call tracepoint AKASHI Takahiro
2014-02-17 19:29 ` Will Deacon
2014-02-19 10:48 ` AKASHI Takahiro
2014-02-07 10:18 ` [PATCH v3 6/6] arm64: Add 'notrace' attribute to unwind_frame() for ftrace AKASHI Takahiro
2014-02-10 14:21 ` [PATCH v3 0/6] arm64: Add ftrace support Kulkarni, Ganapatrao
2014-02-25 9:23 ` [PATCH v4 0/7] " AKASHI Takahiro
2014-02-25 9:23 ` [PATCH v4 1/7] " AKASHI Takahiro
2014-02-25 15:38 ` Kulkarni, Ganapatrao
2014-02-28 5:06 ` AKASHI Takahiro
2014-02-25 9:23 ` [PATCH v4 2/7] arm64: ftrace: Add dynamic " AKASHI Takahiro
2014-02-25 9:23 ` [PATCH v4 3/7] arm64: ftrace: Add CALLER_ADDRx macros AKASHI Takahiro
2014-02-25 9:23 ` [PATCH v4 4/7] ftrace: Add arm64 support to recordmcount AKASHI Takahiro
2014-02-25 9:23 ` [PATCH v4 5/7] arm64: ftrace: Add system call tracepoint AKASHI Takahiro
2014-02-25 9:23 ` [PATCH v4 6/7] arm64: Add 'notrace' attribute to unwind_frame() for ftrace AKASHI Takahiro
2014-02-25 9:23 ` [PATCH v4 7/7] arm64: add __ASSEMBLY__ in asm/insn.h AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 0/7] arm64: Add ftrace support AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 1/7] " AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 2/7] arm64: ftrace: Add dynamic " AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 3/7] arm64: ftrace: Add CALLER_ADDRx macros AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 4/7] ftrace: Add arm64 support to recordmcount AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 5/7] arm64: ftrace: Add system call tracepoint AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 6/7] arm64: Add 'notrace' attribute to unwind_frame() for ftrace AKASHI Takahiro
2014-02-28 5:18 ` [PATCH v5 7/7] arm64: add __ASSEMBLY__ in asm/insn.h AKASHI Takahiro
2014-03-11 14:35 ` [PATCH v5 0/7] arm64: Add ftrace support Will Deacon
2014-03-12 1:47 ` AKASHI Takahiro
2014-03-12 1:58 ` Steven Rostedt
2014-03-12 2:02 ` Steven Rostedt
2014-03-13 10:13 ` [PATCH v6 " AKASHI Takahiro
2014-03-13 10:13 ` [PATCH v6 1/7] arm64: add __ASSEMBLY__ in asm/insn.h AKASHI Takahiro
2014-03-13 12:19 ` Will Deacon
2014-03-13 10:13 ` [PATCH v6 2/7] arm64: Add 'notrace' attribute to unwind_frame() for ftrace AKASHI Takahiro
2014-03-13 12:19 ` Will Deacon
2014-03-13 10:13 ` [PATCH v6 3/7] ftrace: Add arm64 support to recordmcount AKASHI Takahiro
2014-03-13 12:38 ` Will Deacon
2014-03-13 14:57 ` AKASHI Takahiro
2014-03-13 16:05 ` Will Deacon
2014-03-13 10:13 ` [PATCH v6 4/7] arm64: Add ftrace support AKASHI Takahiro
2014-03-13 17:08 ` Will Deacon
2014-03-13 18:27 ` Steven Rostedt
2014-03-13 18:37 ` Will Deacon
2014-03-13 18:49 ` Steven Rostedt
2014-03-14 4:45 ` AKASHI Takahiro
2014-03-14 10:07 ` Will Deacon
2014-03-14 16:13 ` AKASHI Takahiro
2014-03-13 10:13 ` [PATCH v6 5/7] arm64: ftrace: Add dynamic " AKASHI Takahiro
2014-03-13 18:10 ` Will Deacon
2014-03-13 18:33 ` Steven Rostedt
2014-03-14 5:28 ` AKASHI Takahiro
2014-03-14 5:26 ` AKASHI Takahiro
2014-03-13 10:13 ` [PATCH v6 6/7] arm64: ftrace: Add CALLER_ADDRx macros AKASHI Takahiro
2014-03-13 15:54 ` Will Deacon
2014-03-13 18:07 ` Steven Rostedt
2014-03-14 4:55 ` AKASHI Takahiro
2014-03-14 3:00 ` AKASHI Takahiro
2014-03-14 10:09 ` Will Deacon
2014-03-14 16:15 ` AKASHI Takahiro
2014-03-13 10:13 ` [PATCH v6 7/7] arm64: ftrace: Add system call tracepoint AKASHI Takahiro
2014-03-13 16:25 ` Will Deacon
2014-03-14 3:50 ` AKASHI Takahiro
2014-03-15 5:40 ` [PATCH v7 0/7] arm64: Add ftrace support AKASHI Takahiro
2014-03-15 5:40 ` [PATCH v7 1/7] arm64: add __ASSEMBLY__ in asm/insn.h AKASHI Takahiro
2014-03-15 5:40 ` [PATCH v7 2/7] arm64: Add 'notrace' attribute to unwind_frame() for ftrace AKASHI Takahiro
2014-03-15 5:40 ` [PATCH v7 3/7] ftrace: Add arm64 support to recordmcount AKASHI Takahiro
2014-04-16 13:31 ` Will Deacon
2014-04-30 9:54 ` [PATCH v8 0/8] arm64: Add ftrace support AKASHI Takahiro
2014-04-30 9:54 ` [PATCH v8 1/8] ftrace: make CALLER_ADDRx macros more generic AKASHI Takahiro
2014-05-02 18:13 ` Will Deacon
2014-05-02 19:02 ` Steven Rostedt
2014-05-02 19:03 ` Steven Rostedt
2014-05-02 19:19 ` Steven Rostedt
2014-05-12 15:58 ` Will Deacon
2014-05-12 16:05 ` Steven Rostedt
2014-05-12 16:12 ` Will Deacon
2014-05-12 17:23 ` Steven Rostedt
2014-05-20 11:29 ` AKASHI Takahiro
2014-05-20 11:31 ` [PATCH v8_1] " AKASHI Takahiro
2014-06-11 12:34 ` [PATCH v8 1/8] " Geert Uytterhoeven
2014-06-11 13:23 ` [PATCH] arm/ftrace: Fix function_return_addr() to function_return_address() Steven Rostedt
2014-06-11 13:38 ` Geert Uytterhoeven
2014-06-11 13:44 ` Steven Rostedt
2014-04-30 9:54 ` [PATCH v8 2/8] arm64: add __ASSEMBLY__ in asm/insn.h AKASHI Takahiro
2014-04-30 9:54 ` [PATCH v8 3/8] arm64: Add 'notrace' attribute to unwind_frame() for ftrace AKASHI Takahiro
2014-04-30 9:54 ` [PATCH v8 4/8] ftrace: Add arm64 support to recordmcount AKASHI Takahiro
2014-04-30 9:54 ` [PATCH v8 5/8] arm64: Add ftrace support AKASHI Takahiro
2014-05-28 20:19 ` Mark Brown
2014-05-29 8:07 ` Will Deacon
2014-05-29 9:47 ` Mark Brown
2014-04-30 9:54 ` [PATCH v8 6/8] arm64: ftrace: Add dynamic " AKASHI Takahiro
2014-04-30 9:54 ` [PATCH v8 7/8] arm64: ftrace: Add CALLER_ADDRx macros AKASHI Takahiro
2014-04-30 9:54 ` [PATCH v8 8/8] arm64: ftrace: Add system call tracepoint AKASHI Takahiro
2014-03-15 5:45 ` [PATCH v7 4/7] arm64: Add ftrace support AKASHI Takahiro
2014-04-16 13:45 ` Will Deacon
2014-03-15 5:45 ` [PATCH v7 5/7] arm64: ftrace: Add dynamic " AKASHI Takahiro
2014-04-16 13:48 ` Will Deacon
2014-03-15 5:45 ` [PATCH v7 6/7] arm64: ftrace: Add CALLER_ADDRx macros AKASHI Takahiro
2014-04-16 13:52 ` Will Deacon
2014-04-28 10:41 ` AKASHI Takahiro
2014-05-27 13:10 ` [for-next][PATCH] ftrace: Make CALLER_ADDRx macros more generic Steven Rostedt
2014-05-27 18:49 ` Will Deacon
2014-05-29 5:27 ` AKASHI Takahiro
2014-05-29 8:10 ` Will Deacon
2014-03-15 5:45 ` [PATCH v7 7/7] arm64: ftrace: Add system call tracepoint AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402101603.21791.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox