From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 00/23] Move DT kirkwood into mach-mvebu
Date: Thu, 20 Feb 2014 10:45:54 +0100 [thread overview]
Message-ID: <20140220094554.GI11878@lunn.ch> (raw)
In-Reply-To: <20140219222103.GB17826@obsidianresearch.com>
> Thanks, I tested v3 of the patchset.
Great, thanks.
> It boots, but I can't do very much because the watchdog driver doesn't
> build and my system is configured to watchdog timeout if there is no
> watchdog driver.
>
> Presumably the watchdog patchset needs to be a dependency for this? Is
> there a git URL for it?
I don't have a tree with both combined. I guess there is a branch in
https://github.com/MISL-EBU-System-SW/mainline-public.git
with it.
> Also, reviewing my 3.13 Kconfig vs the 3.14 Kconfig with the patch,
> these options are now forced on, and I'd prefer them to be off:
> CONFIG_ARM_PATCH_PHYS_VIRT=y
I suspect that comes from multiplatform.
> CONFIG_GENERIC_PHY=y
> CONFIG_PHY_MVEBU_SATA=y
If you disable SATA, you can disable these two. We have had so much
breakage with this, that i want to keep away from it for a while to
let it settle. I can then go back and see about making it truly
optional.
> And looking at the final kconfig directly a bit:
>
> config ARCH_MVEBU
> bool "Marvell SOCs with Device Tree support" if (ARCH_MULTI_V7 || ARCH_MULTI_V5)
> select ARCH_SUPPORTS_BIG_ENDIAN
> select CLKSRC_MMIO
> select COMMON_CLK
> select GENERIC_CLOCKEVENTS
> select GENERIC_IRQ_CHIP
> select IRQ_DOMAIN
> select MULTI_IRQ_HANDLER
> select PINCTRL
> select PLAT_ORION
> select SPARSE_IRQ
> select CLKDEV_LOOKUP
> select MVEBU_MBUS
> select ZONE_DMA if ARM_LPAE
> select ARCH_REQUIRE_GPIOLIB
> select MIGHT_HAVE_PCI
> select PCI_QUIRKS if PCI
> ^^^^^^^^^^^^^^^^^^^
> This can go now, it was something I added to support the old
> non-dt kirkwood PCI-E driver. The new DT MVEBU driver does not
> require it.
This has nothing directly to do with this patchset. Please could you
supply a patch?
> config MACH_KIRKWOOD
> bool "Marvell Kirkwood boards" if ARCH_MULTI_V5
> select ARCH_HAS_CPUFREQ
> select ARCH_REQUIRE_GPIOLIB
> select CPU_FEROCEON
> select KIRKWOOD_CLK
> select OF_IRQ
> select ORION_IRQCHIP
> select ORION_TIMER
>
> select PCI
> select PCI_QUIRKS
> ^^^^^
> Also unecessary, see above
> select PINCTRL_KIRKWOOD
> select POWER_SUPPLY
> select POWER_RESET
> select POWER_RESET_GPIO
> select REGULATOR
> select REGULATOR_FIXED_VOLTAGE
> select USE_OF
>
> And I feel PCI, POWER_SUPPLY, POWER_RESET, POWER_RESET_GPIO,
> REGULATOR, REGULATOR_FIXED_VOLTAGE should not be forced in the master
> KConfig as not all boards require them.
At the moment, we need PCI in order to get the SoC ID. Gregory has a
patch which will help with this, only selecting the minimum
needed. However, ARCH_KIRKWOOD selected both PCI and PCI_QUIRKS, so i
think removing them should be in a separate cleanup patch, which can
follow once the series is accepted. I added the POWER_* and
REGULATOR_* options. I will move them into mvebu_v5_defconfig and
multi_v5_defconfig instead.
> Maybe make them forced if !EMBEDDED or something?
I think we first need to define what EMBEDDED means. For me a NAS is
an embedded system, and it is various NAS boxes which want these.
> Shouldn't USE_OF and OF_IRQ be in ARCH_MVEBU?
Probably. I'm guessing the others are getting these from
multi_v7_defconfig. I would say this again is something for a cleanup
patch once the series is merged. Dove is also not too far away from
moving in, so i think it makes sense to look at things like this once
we have the complete picture.
Andrew
next prev parent reply other threads:[~2014-02-20 9:45 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 10:19 [PATCH v2 00/23] Move DT kirkwood into mach-mvebu Andrew Lunn
2014-02-15 10:19 ` [PATCH v2 01/23] ARM: Kirkwood: Give pm.c its own header file Andrew Lunn
2014-02-16 2:34 ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 02/23] IRQ: Orion: Fix getting generic chip pointer Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 03/23] ARM: Kirkwood: Convert mv88f6281gtw_ge switch setup to DT Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 04/23] ARM: Kirkwood: Drop printing the SoC type and revision Andrew Lunn
2014-02-16 2:22 ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 05/23] ARM: Kirkwood: Seperate board-dt from common and pcie code Andrew Lunn
2014-02-15 13:18 ` Arnd Bergmann
2014-02-15 14:05 ` Andrew Lunn
2014-02-18 18:37 ` Jason Gunthorpe
2014-02-18 18:42 ` Andrew Lunn
2014-02-18 18:43 ` Arnd Bergmann
2014-02-15 10:20 ` [PATCH v2 06/23] ARM: Kirkwood: ioremap the cpu_config register before using it Andrew Lunn
2014-02-16 2:17 ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 07/23] ARM: Kirkwood: ioremap memory control register Andrew Lunn
2014-02-16 2:35 ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 08/23] ARM: MVEBU: Add ARCH_MULTI_V7 to SoCs Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 09/23] ARM: Orion: Move cache-feroceon-l2.h out of plat-orion Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 10/23] ARM: MM: Add DT binding for Feroceon L2 cache Andrew Lunn
2014-02-15 13:23 ` Arnd Bergmann
2014-02-15 13:59 ` Andrew Lunn
2014-02-15 21:12 ` Arnd Bergmann
2014-02-15 22:39 ` Nicolas Pitre
2014-02-17 23:38 ` Jason Cooper
2014-02-18 9:31 ` Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 11/23] ARM: Kirkwood: Instantiate L2 cache from DT Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 12/23] ARM: Fix default CPU selection for ARCH_MULTI_V5 Andrew Lunn
2014-02-15 20:14 ` Arnd Bergmann
2014-02-17 23:57 ` Jason Cooper
2014-02-15 10:20 ` [PATCH v2 13/23] ARM: Fix MULTI_TLB for feroceon Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 14/23] ARM: MM Enable building Feroceon L2 cache controller with ARCH_MVEBU Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 15/23] ARM: Move kirkwood DT boards into mach-mvebu Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 16/23] ARM: MVEBU: Let kirkwood use the system controller for restart Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 17/23] ARM: MVEBU: Instantiate system controller in kirkwood.dtsi Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 18/23] drivers: Enable building of Kirkwood drivers for mach-mvebu Andrew Lunn
2014-02-17 23:43 ` Jason Cooper
2014-02-15 10:20 ` [PATCH v2 19/23] ARM: MVEBU: Enable mvebu-soc-id on Kirkwood Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 20/23] ARM: config: Add a multi_v5_defconfig Andrew Lunn
2014-02-15 14:03 ` Arnd Bergmann
2014-02-17 23:46 ` Jason Cooper
2014-02-15 10:20 ` [PATCH v2 21/23] ARM: MVEBU: Simplifiy headers and make local Andrew Lunn
2014-02-15 10:20 ` [PATCH v2 22/23] ARM: config: Add mvebu_v5_defconfig Andrew Lunn
2014-02-21 1:19 ` Ezequiel Garcia
2014-02-15 10:20 ` [PATCH v2 23/23] ARM: Kirkwood: Remove DT support Andrew Lunn
2014-02-15 10:22 ` [PATCH v2 00/23] Move DT kirkwood into mach-mvebu Andrew Lunn
2014-02-15 14:06 ` Arnd Bergmann
2014-02-18 18:57 ` Jason Gunthorpe
2014-02-18 19:02 ` Jason Cooper
2014-02-19 22:21 ` Jason Gunthorpe
2014-02-20 9:45 ` Andrew Lunn [this message]
2014-02-20 18:18 ` Jason Gunthorpe
2014-02-20 15:04 ` Ezequiel Garcia
2014-02-21 3:19 ` Ezequiel Garcia
2014-02-21 9:37 ` Andrew Lunn
2014-02-21 17:57 ` Jason Gunthorpe
2014-02-22 1:51 ` Ezequiel Garcia
2014-02-22 3:47 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220094554.GI11878@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox