From: bjorn.andersson@sonymobile•com (Bjorn Andersson)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller
Date: Mon, 24 Feb 2014 10:00:41 -0800 [thread overview]
Message-ID: <20140224180040.GC32621@sonymobile.com> (raw)
In-Reply-To: <5306BFC4.5000005@elopez.com.ar>
On Thu 20 Feb 18:53 PST 2014, Emilio L?pez wrote:
> Hi Bjorn,
>
> El 20/02/14 21:38, Bjorn Andersson escribi?:
[...]
> > + clk_freq = 100000;
> > + if (!of_property_read_u32(node, "clock-frequency", &val))
> > + clk_freq = val;
>
> val will be modified only if no error occurs, so you may rewrite this
> bit as
>
> + u32 clk_freq = 100000;
> ...
> + of_property_read_u32(node, "clock-frequency", &clk_freq)
Seems the two conventions used in the kernel is either your proposal or "if
fail the assign default". So I'll change this.
>
> > +
> > + /* We support frequencies up to FAST Mode (400KHz) */
> > + if (clk_freq <= 0 || clk_freq > 400000) {
>
> And you can drop the < check when it's unsigned.
Indeed!
>
> > + dev_err(qup->dev, "clock frequency not supported %d\n",
> > + clk_freq);
> > + return -EIO;
>
> EIO?
EINVAL
>
> Cheers,
>
> Emilio
Thanks,
Bjorn
next prev parent reply other threads:[~2014-02-24 18:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 0:38 [PATCH v3 0/2] Qualcomm Universal Peripheral (QUP) I2C controller Bjorn Andersson
2014-02-21 0:38 ` [PATCH v3 1/2] i2c: qup: Add device tree bindings information Bjorn Andersson
2014-02-21 11:01 ` Mark Rutland
2014-02-21 0:38 ` [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller Bjorn Andersson
2014-02-21 0:52 ` Joe Perches
2014-02-24 17:51 ` Bjorn Andersson
2014-02-21 2:53 ` Emilio López
2014-02-24 18:00 ` Bjorn Andersson [this message]
2014-02-21 8:16 ` Maxime Ripard
2014-02-24 18:03 ` Bjorn Andersson
2014-02-21 11:06 ` Mark Rutland
2014-02-25 16:07 ` Bjorn Andersson
2014-02-25 16:56 ` Andy Gross
2014-02-21 15:35 ` Kumar Gala
2014-02-24 10:33 ` Ivan T. Ivanov
2014-02-24 17:40 ` Josh Cartwright
2014-02-24 18:05 ` Bjorn Andersson
2014-03-05 16:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224180040.GC32621@sonymobile.com \
--to=bjorn.andersson@sonymobile$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox