From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 7/7] PCI: designware: split samsung and fsl bindings
Date: Fri, 28 Feb 2014 21:03:01 +0100 [thread overview]
Message-ID: <201402282103.01897.arnd@arndb.de> (raw)
In-Reply-To: <1393608523-17509-8-git-send-email-l.stach@pengutronix.de>
On Friday 28 February 2014, Lucas Stach wrote:
> +Required properties:
> +- compatible: "fsl,imx6q-pcie"
> +- reg: base addresse and length of the pcie controller
> +- interrupts: First entry must contain interrupt handle for controller
> + INTA output.
I think this should be documented as "optional" and only for
backwards compatibility with old kernels.
> +- clocks: Must contain an entry for each entry in clock-names.
> + See ../clocks/clock-bindings.txt for details.
> +- clock-names: Must include the following entries:
> + - "pcie_ref_125m"
> + - "sata_ref_100m"
> + - "lvds_gate"
> + - "pcie_axi"
I don't understand why you have completely different clocks here
from the exynos documentation. The clock names should really be
the same. Also, why do you have a "sata_ref_100m" clock?
Is this just driving a device that happens to be on-board
for a specific machine? Same for the "lvds_gate".
Arnd
next prev parent reply other threads:[~2014-02-28 20:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 17:28 [PATCH 0/7] PCI irq mapping fixes and cleanups Lucas Stach
2014-02-28 17:28 ` [PATCH 1/7] ARM: dts: tegra: add PCIe interrupt mapping properties Lucas Stach
2014-02-28 20:27 ` Stephen Warren
2014-02-28 17:28 ` [PATCH 2/7] PCI: tegra: use new OF interrupt mapping when possible Lucas Stach
2014-02-28 17:28 ` [PATCH 3/7] PCI: rcar: " Lucas Stach
2014-02-28 17:28 ` [PATCH 4/7] ARM: dts: exynos5440: fix PCIe interrupt mapping Lucas Stach
2014-03-03 7:40 ` Jingoo Han
2014-03-03 7:53 ` Jingoo Han
2014-03-03 9:26 ` Lucas Stach
2014-02-28 17:28 ` [PATCH 5/7] ARM: dts: imx6: add PCIe interrupt mapping properties Lucas Stach
2014-03-05 5:43 ` Shawn Guo
2014-02-28 17:28 ` [PATCH 6/7] PCI: designware: use new OF interrupt mapping when possible Lucas Stach
2014-03-04 15:05 ` Tim Harvey
2014-02-28 17:28 ` [PATCH 7/7] PCI: designware: split samsung and fsl bindings Lucas Stach
2014-02-28 20:03 ` Arnd Bergmann [this message]
2014-03-04 14:13 ` Lucas Stach
2014-03-04 14:53 ` Arnd Bergmann
2014-03-04 15:34 ` Lucas Stach
2014-03-11 13:34 ` Arnd Bergmann
2014-02-28 20:23 ` Tim Harvey
2014-02-28 20:04 ` [PATCH 0/7] PCI irq mapping fixes and cleanups Arnd Bergmann
2014-03-01 0:53 ` Tim Harvey
2014-03-01 18:30 ` Jason Gunthorpe
2014-03-03 8:11 ` Jingoo Han
2014-03-03 17:49 ` Tim Harvey
2014-03-03 18:01 ` Jason Gunthorpe
2014-03-03 18:28 ` Tim Harvey
2014-03-03 23:40 ` Tim Harvey
2014-03-04 0:01 ` Jason Gunthorpe
2014-03-04 6:04 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402282103.01897.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox