From: bp@alien8•de (Borislav Petkov)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH v2] edac: synopsys: Added EDAC support for zynq ddr ecc controller
Date: Wed, 9 Apr 2014 13:03:39 +0200 [thread overview]
Message-ID: <20140409110339.GF6529@pd.tnic> (raw)
In-Reply-To: <CAGnW=BYJxEkhAitCGi-i6+260-i-+GPrg0yPcY=M+7YmDF6ZRw@mail.gmail.com>
On Wed, Apr 09, 2014 at 11:34:31AM +0530, punnaiah choudary kalluri wrote:
> Since it is recommended in Documentation/kernel-doc-nano-HOWTO.txt
> but also said it is low priority and at the discretion of the MAINTAINER of
> that kernel source file
>
> So, if you recommend not use kernel-doc annotation then i will take care
> in next version.
I don't think there's need for documenting those functions for
kernel-doc - it is an EDAC driver and not some subsystem function with a
lot of users.
> devm_ioremap_resource function will check this condition, so not
> checking for the NULL explicitly
And it would say
dev_err(dev, "invalid resource\n");
so we'll know what fails, ok.
> Since the probe returns error, it it that the devm_ framework will
> clean these resources automatically?
Ah, that's the managed thing, ok.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2014-04-09 11:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 5:23 [RFC PATCH v2] edac: synopsys: Added EDAC support for zynq ddr ecc controller Punnaiah Choudary Kalluri
2014-04-03 15:00 ` Michal Simek
2014-04-08 20:40 ` Borislav Petkov
2014-04-09 6:04 ` punnaiah choudary kalluri
2014-04-09 11:03 ` Borislav Petkov [this message]
2014-04-09 17:45 ` punnaiah choudary kalluri
2014-04-09 17:48 ` Borislav Petkov
2014-04-10 6:01 ` Michal Simek
2014-04-10 9:21 ` Borislav Petkov
2014-04-10 9:49 ` Michal Simek
2014-04-10 10:00 ` Borislav Petkov
2014-04-10 10:05 ` Borislav Petkov
2014-04-10 10:11 ` Michal Simek
2014-04-10 10:10 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409110339.GF6529@pd.tnic \
--to=bp@alien8$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox