From: alexandre.belloni@free-electrons•com (Alexandre Belloni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pinctrl/at91: Fix mask creation in at91_gpio_dbg_show
Date: Mon, 14 Apr 2014 10:14:38 +0200 [thread overview]
Message-ID: <20140414081438.GI2967@piout.net> (raw)
In-Reply-To: <1397241193-2420-1-git-send-email-alexanders83@web.de>
On 11/04/2014 at 20:33:13 +0200, Alexander Stein wrote :
> pin_to_mask expects a bank pin number. So do not add the chip base.
>
I would prefer that you add a description of the effects of the bug as
seen by the user.
> Signed-off-by: Alexander Stein <alexanders83@web•de>
else
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons•com>
> ---
> Mark, thanks for the clarification that pin_to_mask only expects tha bank
> pin number. This wasn't obvious to me.
> drivers/pinctrl/pinctrl-at91.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index 63176f2..2da0e6e 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -1205,8 +1205,7 @@ static void at91_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
> void __iomem *pio = at91_gpio->regbase;
>
> for (i = 0; i < chip->ngpio; i++) {
> - unsigned pin = chip->base + i;
> - unsigned mask = pin_to_mask(pin);
> + unsigned mask = pin_to_mask(i);
> const char *gpio_label;
> u32 pdsr;
>
> --
> 1.9.2
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-04-14 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 15:35 [PATCH] pinctrl/at91: Fix pin_to_mask Alexander Stein
2014-04-11 15:42 ` Jean-Christophe PLAGNIOL-VILLARD
2014-04-11 15:45 ` Alexander Stein
2014-04-11 17:53 ` Mark Roszko
2014-04-11 18:33 ` [PATCH] pinctrl/at91: Fix mask creation in at91_gpio_dbg_show Alexander Stein
2014-04-14 8:14 ` Alexandre Belloni [this message]
2014-04-14 18:53 ` [PATCH v2] " Alexander Stein
2014-04-16 7:55 ` Nicolas Ferre
2014-04-22 21:46 ` Linus Walleij
2014-04-14 8:19 ` [PATCH] " Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414081438.GI2967@piout.net \
--to=alexandre.belloni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox