Subject: [PATCH] clocksource: efm32: let CLKSRC_EFM32 select CLKSRC_OF

From: [email-masked] (Uwe Kleine-König)
Date: Wed, 16 Apr 2014 21:30:36 +0200

Hello,

On Wed, Apr 16, 2014 at 01:51:17PM -0500, Rob Herring wrote:
> On Wed, Apr 16, 2014 at 1:40 PM, Uwe Kleine-K?nig
> <[email-masked]> wrote:
> > The efm32 timer driver is only usable with CLKSRC_OF, so it makes sense
> > to let its Kconfig symbol select it. For compile coverage testing it's not
> > needed though, so only select it if ARCH_EFM32 is enabled.
> >
> > This allows to drop ARCH_EFM32 selecting CLKSRC_OF which is done here
> > for simplicity, too.
> >
> > Reported-by: Rob Herring <[email-masked]>
> > Signed-off-by: Uwe Kleine-K?nig <[email-masked]>
> > ---
> > [...]
> > diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> > --- a/drivers/clocksource/Kconfig
> > +++ b/drivers/clocksource/Kconfig
> > @@ -80,6 +80,7 @@ config CLKSRC_EFM32
> >         bool "Clocksource for Energy Micro's EFM32 SoCs" if !ARCH_EFM32
> >         depends on OF && ARM && (ARCH_EFM32 || COMPILE_TEST)
> >         select CLKSRC_MMIO
> > +       select CLKSRC_OF if ARCH_EFM32
> 
> You already depend on OF, so I believe you don't need the if here.
Rob and I discussed this shortly on irc, the summary is that the if is
not needed to prevent Kconfig breakage but adds more flexibility for the
COMPILE_TEST case. In the end Rob said:

	1397676012 < robher> you can add my ack.

which would be:

Acked-by: Rob Herring <[email-masked]>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |