From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC 3/3] asm-generic: Drop renameat syscall from default list
Date: Wed, 23 Apr 2014 14:18:04 +0200 [thread overview]
Message-ID: <201404231418.05174.arnd@arndb.de> (raw)
In-Reply-To: <1398247687-13453-4-git-send-email-james.hogan@imgtec.com>
On Wednesday 23 April 2014, James Hogan wrote:
> The new renameat2 syscall provides all the functionality provided by the
> renameat syscall and adds flags, so future architectures won't need to
> include renameat.
>
> Therefore drop the renameat syscall from the generic syscall list unless
> __ARCH_WANT_RENAMEAT is defined by the architecture's unistd.h prior to
> including asm-generic/unistd.h, and adjust all architectures using the
> generic syscall list to define it so that no in-tree architectures are
> affected.
I should have read this one before replying to patch 2 ;-)
> Signed-off-by: James Hogan <james.hogan@imgtec•com>
> Cc: Arnd Bergmann <arnd@arndb•de>
> Cc: linux-arch at vger.kernel.org
> Cc: Vineet Gupta <vgupta@synopsys•com>
> Cc: Catalin Marinas <catalin.marinas@arm•com>
> Cc: Will Deacon <will.deacon@arm•com>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Mark Salter <msalter@redhat•com>
> Cc: Aurelien Jacquiot <a-jacquiot@ti•com>
> Cc: linux-c6x-dev at linux-c6x.org
> Cc: Richard Kuo <rkuo@codeaurora•org>
> Cc: linux-hexagon at vger.kernel.org
> Cc: linux-metag at vger.kernel.org
> Cc: Jonas Bonn <jonas@southpole•se>
> Cc: linux at lists.openrisc.net
> Cc: Chen Liqin <liqin.linux@gmail•com>
> Cc: Lennox Wu <lennox.wu@gmail•com>
> Cc: Chris Metcalf <cmetcalf@tilera•com>
> Cc: Guan Xuetao <gxt@mprc•pku.edu.cn>
> ---
> Is this the approach we want to take to keep the default syscall list
> minimal? We could for example have made renameat2 use the renameat
> syscall number for new arches, but it seemed best to leave a gap for new
> arches to improve consistency of numbering.
I think leaving the hole is best.
> This patch is a no-op for arches in tree, so there's no harm for this to
> wait for the v3.16 merge window.
Sounds good. I guess I'll have to put this into my asm-generic tree
then, unless I can get the nios2 maintainers to pick it up.
If you don't mind, can you submit the first two patches to Linus
directly?
Arnd
next prev parent reply other threads:[~2014-04-23 12:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 10:08 [PATCH 0/3] asm-generic: Add renameat2, drop renameat by default James Hogan
2014-04-23 10:08 ` [PATCH 1/3] asm-generic: Add renameat2 syscall James Hogan
2014-04-23 12:13 ` Arnd Bergmann
2014-04-23 10:08 ` [RFC 3/3] asm-generic: Drop renameat syscall from default list James Hogan
2014-04-23 12:18 ` Arnd Bergmann [this message]
2014-04-23 12:41 ` James Hogan
2014-04-29 11:24 ` Szeredi Miklos
2014-05-14 16:16 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404231418.05174.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox