From: lee.jones@linaro•org (Lee Jones)
To: linux-arm-kernel@lists•infradead.org
Subject: [RESUBMIT RFC PATCH v2 3/3] drivers: mfd: Add support for Exynos PMU driver
Date: Tue, 29 Apr 2014 10:27:23 +0100 [thread overview]
Message-ID: <20140429092723.GG29462@lee--X1> (raw)
In-Reply-To: <535F5AA7.2050001@samsung.com>
> >>This patch moves Exynos PMU driver implementation from
> >>"arm/mach-exynos" to "drivers/mfd".
> >>This driver is mainly used for setting misc bits of register from PMU IP
> >>of Exynos SoC which will be required to configure before Suspend/Resume.
> >>Currently all these settings are done in "arch/arm/mach-exynos/pmu.c" but
> >>moving ahead for ARM64 based SoC support, there is a need of DT based
> >>implementation of PMU driver.
> >>This driver uses already existing DT binding information.
> >>
> >>CC: Sangbeom Kim <sbkim73@samsung•com>
> >>CC: Samuel Ortiz <sameo@linux•intel.com>
> >>CC: Lee Jones <lee.jones@linaro•org>
> >>Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung•com>
> >>---
> >> arch/arm/mach-exynos/Kconfig | 2 ++
> >> arch/arm/mach-exynos/Makefile | 2 --
> >> drivers/mfd/Kconfig | 9 +++++++++
> >> drivers/mfd/Makefile | 1 +
> >> arch/arm/mach-exynos/pmu.c => drivers/mfd/exynos-pmu.c | 0
> >> 5 files changed, 12 insertions(+), 2 deletions(-)
> >> rename arch/arm/mach-exynos/pmu.c => drivers/mfd/exynos-pmu.c (100%)
> >So I just took a look at the code as zero changes looks suspicious to
> >me. The driver can not simply be copied and pasted into the MFD
> >subsystem in its current state.
> >
> >The fundamental question is; is this chip actually an MFD? What does
> >it do besides Power Management?
>
> Exynos PMU chip controls different power states of Exynos, so mainly it
> does power management related stuff. Apart from this it has few registers
> which controls PHY of various IP blocks of Exynos such as USB, HDMI,
> ADC etc. But these phy controlling register are currently being accessed
> via "syscon" driver provided regmap APIs. For same the same reason
> Exynos PMU has second compatibility string as "syscon".
I suggest that this is not suitable for the MFD subsystem then.
Try drivers/power.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2014-04-29 9:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 12:20 [RESUBMIT RFC PATCH v2 0/3] Add support for Exynos PMU driver Pankaj Dubey
2014-04-28 12:20 ` [RESUBMIT RFC PATCH v2 1/3] ARM: EXYNOS: Move PMU specific definitions from common.h Pankaj Dubey
2014-04-28 12:20 ` [RESUBMIT RFC PATCH v2 2/3] ARM: EXYNOS: Move pmu specific header files under "linux/mfd/samsung" Pankaj Dubey
2014-04-28 12:17 ` Lee Jones
2014-04-28 12:20 ` [RESUBMIT RFC PATCH v2 3/3] drivers: mfd: Add support for Exynos PMU driver Pankaj Dubey
2014-04-28 12:18 ` Lee Jones
2014-04-28 12:26 ` Lee Jones
2014-04-28 17:37 ` Catalin Marinas
2014-04-29 8:05 ` Pankaj Dubey
2014-04-29 7:54 ` Pankaj Dubey
2014-04-29 9:27 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429092723.GG29462@lee--X1 \
--to=lee.jones@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox