From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support
Date: Wed, 7 May 2014 15:21:50 +0200 [thread overview]
Message-ID: <20140507132150.GA23936@lunn.ch> (raw)
In-Reply-To: <20140507114006.466347a0@free-electrons.com>
On Wed, May 07, 2014 at 11:40:06AM +0200, Thomas Petazzoni wrote:
> Dear Andrew Lunn,
>
> On Tue, 6 May 2014 15:33:41 +0200, Andrew Lunn wrote:
>
> > > + priv->phy = devm_phy_get(&pdev->dev, "usb");
> > > + if (!IS_ERR(priv->phy)) {
> > > + err = phy_init(priv->phy);
> > > + if (err)
> > > + goto err2;
> > > +
> > > + err = phy_power_on(priv->phy);
> > > + if (err)
> > > + goto err3;
> > > + }
> >
> > Hi Gregory
> >
> > What about EPROBE_DEFERRED?
>
> In v4 (to be submitted soon), I've changed this to:
>
> priv->phy = devm_phy_optional_get(&pdev->dev, "usb");
> if (IS_ERR(priv->phy)) {
> err = PTR_ERR(priv->phy);
> goto err_phy_get;
> } else {
> err = phy_init(priv->phy);
> if (err)
> goto err_phy_init;
>
> err = phy_power_on(priv->phy);
> if (err)
> goto err_phy_power_on;
> }
>
> Thanks to devm_phy_optional_get(), the fact of not having a PHY in the
> DT is not considered an error. So on any error from
> devm_phy_optional_get() (including -EPROBE_DEFER), we simply bail out.
> Does this looks good?
Hi Thomas
That looks good.
To avoid the SATA phy problems we had last time, i would like to test
this on a few systems. Please could you let me know what branch v4 is
in when it is ready.
Thanks
Andrew
next prev parent reply other threads:[~2014-05-07 13:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 0:13 [PATCH v3 00/20] USB support for Armada 38x and Armada 375 Gregory CLEMENT
2014-05-06 0:13 ` [PATCH v3 01/20] usb: ehci-orion: Fix clock reference leaking Gregory CLEMENT
2014-05-06 14:30 ` Alan Stern
2014-05-07 9:38 ` Thomas Petazzoni
2014-05-06 0:13 ` [PATCH v3 02/20] usb: ehci-orion: Add the optional PHY support Gregory CLEMENT
2014-05-06 13:33 ` Andrew Lunn
2014-05-07 9:40 ` Thomas Petazzoni
2014-05-07 13:21 ` Andrew Lunn [this message]
2014-05-07 13:56 ` Thomas Petazzoni
2014-05-06 0:13 ` [PATCH v3 03/20] usb: host: xhci-plat: Sort the headers in alphabetic order Gregory CLEMENT
2014-05-06 0:13 ` [PATCH v3 04/20] usb: xhci: add a platform-private field Gregory CLEMENT
2014-05-06 15:40 ` Felipe Balbi
2014-05-06 0:14 ` [PATCH v3 05/20] usb: host: xhci-plat: Add clocks support Gregory CLEMENT
2014-05-06 3:00 ` Felipe Balbi
2014-05-06 13:41 ` Jason Cooper
2014-05-07 12:26 ` Thomas Petazzoni
2014-05-06 0:14 ` [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x Gregory CLEMENT
2014-05-06 11:34 ` Bartlomiej Zolnierkiewicz
2014-05-06 11:57 ` Arnd Bergmann
2014-05-06 12:10 ` Thomas Petazzoni
2014-05-06 12:21 ` Arnd Bergmann
2014-05-06 12:42 ` Thomas Petazzoni
2014-05-06 15:39 ` Felipe Balbi
2014-05-07 10:23 ` Thomas Petazzoni
2014-05-07 15:10 ` Felipe Balbi
2014-05-07 15:14 ` Thomas Petazzoni
2014-05-06 0:14 ` [PATCH v3 07/20] xhci-platform: Add a new controller using xhci: " Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 08/20] ARM: mvebu: Add Device Tree description of xHCI hosts on " Gregory CLEMENT
2014-05-06 13:42 ` Andrew Lunn
2014-05-06 0:14 ` [PATCH v3 09/20] ARM: mvebu: Add Device Tree description of the EHCI host " Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 10/20] ARM: mvebu: Add USB3 support for " Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 11/20] ARM: configs: Add usb_xhci_mvebu to mvebu_v7_defconfig Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 12/20] ARM: configs: Add usb_xhci_mvebu to multi_v7_defconfig Gregory CLEMENT
2014-05-06 13:46 ` Jason Cooper
2014-05-06 0:14 ` [PATCH v3 13/20] usb: host: xhci-plat: Add support for the Armada 375 Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 14/20] xhci-platform: Add a new controller using xHCI: " Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 15/20] ARM: mvebu: Add Device Tree description of USB cluster controller on " Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 16/20] dt: binding: Armada 375 USB cluster Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 17/20] phy: Add support for USB cluster on the Armada 375 SoC Gregory CLEMENT
2014-05-06 11:37 ` Bartlomiej Zolnierkiewicz
2014-05-07 12:50 ` Thomas Petazzoni
2014-05-06 13:54 ` Andrew Lunn
2014-05-07 12:52 ` Thomas Petazzoni
2014-05-06 20:53 ` Ezequiel Garcia
2014-05-07 12:55 ` Thomas Petazzoni
2014-05-06 0:14 ` [PATCH v3 18/20] ARM: mvebu: Add USB3 support for Armada 375 Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 19/20] ARM: mvebu: Add Device Tree description of the xHCI host on " Gregory CLEMENT
2014-05-06 0:14 ` [PATCH v3 20/20] ARM: mvebu: Add Device Tree description of the EHCI " Gregory CLEMENT
[not found] ` <loom.20140507T102941-222@post.gmane.org>
2014-05-07 9:21 ` [PATCH v3 00/20] USB support for Armada 38x and " Sebastian Hesselbarth
2014-05-07 9:48 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507132150.GA23936@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox