From: gregkh@linuxfoundation•org (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] usb: core: Kconfig: refine the description for CONFIG_USB_OTG
Date: Wed, 14 May 2014 16:08:30 +0200 [thread overview]
Message-ID: <20140514140830.GA16307@kroah.com> (raw)
In-Reply-To: <dc4c63c13058468db8ad8ec4a22204e8@BN1PR03MB235.namprd03.prod.outlook.com>
On Wed, May 14, 2014 at 06:24:51AM +0000, Peter Chen wrote:
>
> >
> > On Tue, May 13, 2014 at 01:11:44PM +0200, Greg KH wrote:
> > > On Tue, May 13, 2014 at 10:19:27AM +0800, Peter Chen wrote:
> > > > the user should only select it when the board supports HNP and SRP,
> > > > it should NOT be selected if the board only supports dual-role
> > > > switch through ID pin.
> > > >
> > > > There is a discussion for it:
> > > > http://marc.info/?l=linux-arm-kernel&m=139994896101516&w=2
> > > > http://marc.info/?l=linux-usb&m=139994881701504&w=2
> > > >
> > > > Signed-off-by: Peter Chen <peter.chen@freescale•com>
> > > > ---
> > > > drivers/usb/core/Kconfig | 12 +++++++-----
> > > > 1 files changed, 7 insertions(+), 5 deletions(-)
> > > >
> > > > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> > > > index cb8e991..158048b 100644
> > > > --- a/drivers/usb/core/Kconfig
> > > > +++ b/drivers/usb/core/Kconfig
> > > > @@ -54,13 +54,15 @@ config USB_OTG
> > > > default n
> > > > help
> > > > The most notable feature of USB OTG is support for a
> > > > - "Dual-Role" device, which can act as either a device
> > > > - or a host. The initial role is decided by the type of
> > > > - plug inserted and can be changed later when two dual
> > > > - role devices talk to each other.
> > > > + otg device, which can act as either a device or a host.
> > > > + The initial role is decided by the type of plug inserted
> > > > + and can be changed using HNP (Host Negotiation Protocol)
> > > > + later when two otg devices talk to each other.
> > > >
> > > > Select this only if your board has Mini-AB/Micro-AB
> > > > - connector.
> > > > + connector and supports HNP and SRP (Session Request Protocol).
> > > > + If the board only supports dual-role switch through ID
> > > > + pin, this configuration should not be selected.
> > >
> > > That's really lame. What happened to our "all modconfig should work"
> > > goal? Why can't you dynamically detect that this is not a config that
> > > works and handle it?
> > >
>
> If CONFIG_USB_OTG and CONFIG_USB_OTG_WHITELIST are set, most of usb devices
> will not work when connect to host for current code.
>
> So, we need a feature flag for hcd and gadget, and set this OTG feature flag
> if the platform supports it (using dtb or platform data).
Sounds reasonable, and much nicer than just trying to point to a help
configuration file that no one will ever read :)
greg k-h
next prev parent reply other threads:[~2014-05-14 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 2:19 [PATCH 1/1] usb: core: Kconfig: refine the description for CONFIG_USB_OTG Peter Chen
2014-05-13 11:11 ` Greg KH
2014-05-13 15:46 ` Felipe Balbi
2014-05-14 6:24 ` Peter Chen
2014-05-14 14:08 ` Greg KH [this message]
2014-05-14 14:35 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514140830.GA16307@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox