From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] [RFC] ARM: perf: allow tracing with kernel tracepoints events
Date: Mon, 19 May 2014 16:39:15 +0100 [thread overview]
Message-ID: <20140519153915.GI15130@arm.com> (raw)
In-Reply-To: <1400252476-20128-1-git-send-email-jean.pihet@linaro.org>
Hi Jean,
On Fri, May 16, 2014 at 04:01:16PM +0100, Jean Pihet wrote:
> When tracing with tracepoints events the IP and CPSR are set to 0,
> preventing the perf code to resolve the symbols:
>
> ./perf record -e kmem:kmalloc cal
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.007 MB perf.data (~321 samples) ]
>
> ./perf report
> Overhead Command Shared Object Symbol
> ........ ....... ............. ...........
> 40.78% cal [unknown] [.]00000000
> 31.6% cal [unknown] [.]00000000
>
> The examination of the gathered samples (perf report -D) shows the IP
> is set to 0 and that the samples are considered as user space samples,
> while the IP should be set from the registers and the samples should be
> considered as kernel samples.
>
> The fix is to implement perf_arch_fetch_caller_regs for ARM, which
> fills the necessary registers: ip, lr, sp and cpsr (used to check
> the user mode property of the samples).
>
> Heavily inspired from arch/arm/include/asm/kexec.h.
>
> Reported by Sneha Priya on linaro-dev, cf.
> http://lists.linaro.org/pipermail/linaro-dev/2014-May/017151.html
>
> Signed-off-by: Jean Pihet <jean.pihet@linaro•org>
> Cc: Will Deacon <will.deacon@arm•com>
> Reported-by: Sneha Priya <sneha.cse@hotmail•com>
> ---
> arch/arm/include/asm/perf_event.h | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/include/asm/perf_event.h b/arch/arm/include/asm/perf_event.h
> index 7558775..d466e39 100644
> --- a/arch/arm/include/asm/perf_event.h
> +++ b/arch/arm/include/asm/perf_event.h
> @@ -26,6 +26,19 @@ struct pt_regs;
> extern unsigned long perf_instruction_pointer(struct pt_regs *regs);
> extern unsigned long perf_misc_flags(struct pt_regs *regs);
> #define perf_misc_flags(regs) perf_misc_flags(regs)
> +
> +#define perf_arch_fetch_caller_regs(regs, __ip) { \
> + instruction_pointer(regs)= (__ip); \
> + __asm__ __volatile__ ( \
> + "mov %[_ARM_sp], sp\n\t" \
> + "str lr, %[_ARM_lr]\n\t" \
> + "mrs %[_ARM_cpsr], cpsr\n\t" \
> + : [_ARM_cpsr] "=r" (regs->ARM_cpsr), \
> + [_ARM_sp] "=r" (regs->ARM_sp), \
> + [_ARM_lr] "=o" (regs->ARM_lr) \
> + : : "memory" \
> + ); \
> +}
Why do we need to save lr? If it's for unwinding, what about fp? Also, why
do you have a "memory" clobber and why is this block marked volatile?
Will
next prev parent reply other threads:[~2014-05-19 15:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 15:01 [PATCH] [RFC] ARM: perf: allow tracing with kernel tracepoints events Jean Pihet
2014-05-19 15:39 ` Will Deacon [this message]
2014-05-19 15:58 ` Jean Pihet
2014-06-17 17:11 ` [PATCH] " Jean Pihet
2014-06-18 12:53 ` Will Deacon
2014-06-20 8:10 ` Jean Pihet
2014-06-25 9:01 ` Will Deacon
2014-06-25 14:54 ` Jean Pihet
2014-06-26 9:00 ` Will Deacon
2014-06-27 14:53 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140519153915.GI15130@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox