From: gregkh@linuxfoundation•org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RESEND 3/5] tty/serial: Add GPIOLIB helpers for controlling modem lines
Date: Wed, 28 May 2014 12:47:21 -0700 [thread overview]
Message-ID: <20140528194721.GA12869@kroah.com> (raw)
In-Reply-To: <20140528194550.GA12735@kroah.com>
On Wed, May 28, 2014 at 12:45:50PM -0700, Greg Kroah-Hartman wrote:
> On Tue, May 13, 2014 at 08:20:43PM +0200, Richard Genoud wrote:
> > This patch add some helpers to control modem lines (CTS/RTS/DSR...) via
> > GPIO.
> > This will be useful for many boards which have a serial controller that
> > only handle CTS/RTS pins (or even just RX/TX).
> >
> > Signed-off-by: Richard Genoud <richard.genoud@gmail•com>
> > Tested-by: Yegor Yefremov <yegorslists@googlemail•com>
> > ---
> > Documentation/serial/driver | 25 ++++++
> > drivers/tty/serial/Kconfig | 3 +
> > drivers/tty/serial/Makefile | 3 +
> > drivers/tty/serial/serial_mctrl_gpio.c | 143 ++++++++++++++++++++++++++++++++
> > drivers/tty/serial/serial_mctrl_gpio.h | 110 ++++++++++++++++++++++++
> > 5 files changed, 284 insertions(+)
> > create mode 100644 drivers/tty/serial/serial_mctrl_gpio.c
> > create mode 100644 drivers/tty/serial/serial_mctrl_gpio.h
> >
> > diff --git a/Documentation/serial/driver b/Documentation/serial/driver
> > index c3a7689..3bba1ae 100644
> > --- a/Documentation/serial/driver
> > +++ b/Documentation/serial/driver
> > @@ -429,3 +429,28 @@ thus:
> > struct uart_port port;
> > int my_stuff;
> > };
> > +
> > +Modem control lines via GPIO
> > +----------------------------
> > +
> > +Some helpers are provided in order to set/get modem control lines via GPIO.
> > +
> > +mctrl_gpio_init(dev, idx):
> > + This will get the {cts,rts,...}-gpios from device tree if they are
> > + present and request them, set direction etc, and return an
> > + allocated structure. devm_* functions are used, so there's no need
> > + to call mctrl_gpio_free().
> > +
> > +mctrl_gpio_free(dev, gpios):
> > + This will free the requested gpios in mctrl_gpio_init().
> > + As devm_* function are used, there's generally no need to call
> > + this function.
> > +
> > +mctrl_gpio_to_gpiod(gpios, gidx)
> > + This returns the gpio structure associated to the modem line index.
> > +
> > +mctrl_gpio_set(gpios, mctrl):
> > + This will sets the gpios according to the mctrl state.
> > +
> > +mctrl_gpio_get(gpios, mctrl):
> > + This will update mctrl with the gpios values.
> > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> > index 5d9b01a..95afd31 100644
> > --- a/drivers/tty/serial/Kconfig
> > +++ b/drivers/tty/serial/Kconfig
> > @@ -1510,4 +1510,7 @@ config SERIAL_ST_ASC_CONSOLE
> >
> > endmenu
> >
> > +config SERIAL_MCTRL_GPIO
> > + tristate
>
> Why is this added here? Who is going to use it?
Ah, the next patch does, nevermind...
next prev parent reply other threads:[~2014-05-28 19:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 18:20 [PATCH RESEND 0/5] tty/serial: Add helpers to use GPIOs to control modem lines and implement atmel_serial.c Richard Genoud
2014-05-13 18:20 ` [PATCH RESEND 1/5] tty/serial: atmel_serial: Fix device tree documentation Richard Genoud
2014-05-13 18:20 ` [PATCH RESEND 2/5] ARM: at91: gpio: implement get_direction Richard Genoud
2014-05-13 18:20 ` [PATCH RESEND 3/5] tty/serial: Add GPIOLIB helpers for controlling modem lines Richard Genoud
2014-05-20 9:26 ` Yegor Yefremov
2014-05-28 19:45 ` Greg Kroah-Hartman
2014-05-28 19:47 ` Greg Kroah-Hartman [this message]
2014-05-13 18:20 ` [PATCH RESEND 4/5] tty/serial: at91: use mctrl_gpio helpers Richard Genoud
2014-05-13 18:20 ` [PATCH RESEND 5/5] tty/serial: at91: add interrupts for modem control lines Richard Genoud
2014-08-10 19:33 ` Peter Hurley
2014-09-01 9:26 ` Richard Genoud
2014-09-02 11:40 ` Peter Hurley
2014-09-03 10:50 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528194721.GA12869@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox