From: mark.rutland@arm•com (Mark Rutland)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency
Date: Fri, 30 May 2014 14:08:27 +0100 [thread overview]
Message-ID: <20140530130827.GK24233@leverpostej> (raw)
In-Reply-To: <1401440477-4328-3-git-send-email-thomas.ab@samsung.com>
Hi,
Apologies for being somewhat late w.r.t. review on this.
On Fri, May 30, 2014 at 10:01:17AM +0100, Thomas Abraham wrote:
> From: Thomas Abraham <thomas.ab@samsung•com>
>
> Add a new optional boost-frequency binding for specifying the frequencies
> usable in boost mode.
>
> Cc: Rob Herring <robh+dt@kernel•org>
> Cc: Pawel Moll <pawel.moll@arm•com>
> Cc: Mark Rutland <mark.rutland@arm•com>
> Cc: Ian Campbell <ijc+devicetree@hellion•org.uk>
> Cc: Kumar Gala <galak@codeaurora•org>
> Signed-off-by: Thomas Abraham <thomas.ab@samsung•com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro•org>
> Acked-by: Nishanth Menon <nm@ti•com>
> Acked-by: Lukasz Majewski <l.majewski@samsung•com>
> ---
> .../devicetree/bindings/cpufreq/cpufreq-boost.txt | 38 ++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
> new file mode 100644
> index 0000000..63ed0fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-boost.txt
> @@ -0,0 +1,38 @@
> +* Device tree binding for CPU boost frequency (aka over-clocking)
> +
> +Certain CPU's can be operated in optional 'boost' mode (or sometimes referred as
Nit: CPUs (we're not greengrocers [1])
> +overclocking) in which the CPU can operate at frequencies which are not
> +specified by the manufacturer as CPU's operating frequency.
> +
> +Optional Properties:
> +- boost-frequencies: list of frequencies in KHz to be used only in boost mode.
> + This list should be a subset of frequencies listed in "operating-points"
> + property. Refer to Documentation/devicetree/bindings/power/opp.txt for
> + details about "operating-points" property.
What is 'boost-mode'?
What are the limitations on boost frequencies? When is a CPU expected to
go to these frequencies and for now long? When should I as a dt author
place elements in boost-frequencies?
Why are these in both operating-points and boost-frequencies? It'll be
really easy to accidentally forget to mark something as a
boost-frequency this way. Why not have a boost-points instead?
> +
> +Example:
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + cpu at 0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg = <0>;
> +
> + operating-points = <
> + 1500000 1350000
> + 1400000 1287500
> + 1300000 1250000
> + 1200000 1187500
> + 1100000 1137500
> + 1000000 1087500
> + >;
> + boost-frequencies = <1500000 1400000>;
This is more of a general issue, but I hate the whole cpufreq-cpu0 way
of assuming that all CPUs mirror CPU0.
It would be nicer if either this were dropped in /cpus or repeated
per-cpu.
Cheers,
Mark.
> + };
> + cpu at 1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a9";
> + reg = <1>;
> + };
> + };
> --
> 1.7.9.5
>
>
[1] http://en.wikipedia.org/wiki/Apostrophe#Superfluous_apostrophes_.28.22greengrocers.27_apostrophes.22.29
next prev parent reply other threads:[~2014-05-30 13:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 9:01 [PATCH v6 0/2] cpufreq: opp: Add device tree based lookup of boost mode frequency Thomas Abraham
2014-05-30 9:01 ` [PATCH v6 1/2] cpufreq / OPP: Allow boost frequency to be looked up from device tree Thomas Abraham
2014-05-30 9:01 ` [PATCH v6 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency Thomas Abraham
2014-05-30 13:08 ` Mark Rutland [this message]
2014-05-30 18:05 ` Thomas Abraham
2014-05-30 18:15 ` Tomasz Figa
2014-05-30 18:33 ` Thomas Abraham
2014-05-30 18:35 ` Tomasz Figa
2014-05-30 18:38 ` Sudeep Holla
2014-05-30 18:41 ` Tomasz Figa
2014-05-30 18:48 ` Sudeep Holla
2014-05-30 18:55 ` Mark Rutland
2014-05-30 19:50 ` Nishanth Menon
2014-05-30 20:02 ` Tomasz Figa
2014-05-30 20:13 ` Nishanth Menon
2014-05-30 20:19 ` Tomasz Figa
2014-05-30 20:33 ` Nishanth Menon
2014-05-30 20:43 ` Tomasz Figa
2014-05-30 21:01 ` Nishanth Menon
2014-05-30 20:45 ` Rob Herring
2014-05-30 20:59 ` Nishanth Menon
2014-05-30 12:19 ` [PATCH v6 0/2] cpufreq: opp: Add device tree based lookup of " Rafael J. Wysocki
2014-05-30 14:47 ` Rafael J. Wysocki
2014-05-30 18:07 ` Thomas Abraham
2014-05-30 21:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140530130827.GK24233@leverpostej \
--to=mark.rutland@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox