From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 0/4] arm:dma-mapping Refactoring iommu dma-mapping code
Date: Tue, 3 Jun 2014 14:01:56 +0100 [thread overview]
Message-ID: <20140603130156.GG23149@arm.com> (raw)
In-Reply-To: <1401704363-31052-1-git-send-email-ritesh.harjani@gmail.com>
On Mon, Jun 02, 2014 at 11:19:19AM +0100, ritesh.harjani at gmail.com wrote:
> From: Ritesh Harjani <ritesh.harjani@gmail•com>
> Hi All,
Hi Ritesh,
Thanks for the new patches. I have a few comments on the series as a whole.
> This patch series is to refractor iommu related common code from
> arch/arm/dma-mapping.c to lib/iommu-helper.c based on the various
> discussions with the maintainers/experts [1].
>
> Currently the only user of the common lib/iommu-helper code will
> be ARM & ARM64 but later various architecture might try to use this
> iommu lib helper functions.
>
> Major change of this refactoring starts with bringing out struct dma_iommu_mapping
> *mapping variable from arch/arm/include/asm/device.h to include/linux/device.h
> and by moving out complete structure defination of dma_iommu_mapping to
> inclue/linux/iommu-helper.h. Link [2] give more details on why this was done,
> also this change got approval from Will Daecon [2].
Well, I can't approve changes to include/linux/device.h, so that probably
needs to be acked by Grant and/or Greg. Could you split that patch out into
a separate change please, so that it can go in independently?
Also, I think you could merge patches 2 and 3, no?
> There are 1/2 more function definitions which I can think of moving out, but
> those can be done once this patch series is approved as those are not very
> big changes.
This certainly looks good to start with, although I think you should
consider renaming the functions in the helper library so that they aren't
prefixed with double underscores. Maybe iommu_helper_* instead?
Finally, please drop the ChangeId entries from your commit messages (and
you've consistently misspelled refactor as refractor).
Will
prev parent reply other threads:[~2014-06-03 13:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 10:19 [PATCH 0/4] arm:dma-mapping Refactoring iommu dma-mapping code ritesh.harjani at gmail.com
2014-06-02 10:19 ` [PATCH 1/4] arm: dma-iommu: Move out dma_iommu_mapping struct ritesh.harjani at gmail.com
2014-06-02 10:19 ` [PATCH 2/4] arm: dma-mapping: Refractor attach/detach dev function calls ritesh.harjani at gmail.com
2014-06-02 10:19 ` [PATCH 3/4] arm: dma-mapping: Refractor iommu_alloc/free funcs ritesh.harjani at gmail.com
2014-06-02 10:19 ` [PATCH 4/4] arm:dma-iommu: Move out complete func defs ritesh.harjani at gmail.com
2014-06-03 13:01 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603130156.GG23149@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox