From: catalin.marinas@arm•com (Catalin Marinas)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: ptrace: fix empty registers set in prstatus of aarch32 process core
Date: Tue, 3 Jun 2014 18:11:48 +0100 [thread overview]
Message-ID: <20140603171148.GE10126@arm.com> (raw)
In-Reply-To: <20140603163341.GS23149@arm.com>
On Tue, Jun 03, 2014 at 05:33:41PM +0100, Will Deacon wrote:
> On Tue, Jun 03, 2014 at 05:27:24PM +0100, Victor Kamensky wrote:
> > Hi Will,
> >
> > On 3 June 2014 07:46, Will Deacon <will.deacon@arm•com> wrote:
> > > Hi Victor,
> > >
> > > Thanks for both the fix and the detailed explanation!
> > >
> > > On Tue, Jun 03, 2014 at 06:46:09AM +0100, Victor Kamensky wrote:
> > >> Currently core file of aarch32 process prstatus note has empty
> > >> registers set. As result aarch32 core files create by V8 kernel are
> > >> not very useful.
> > >>
> > >> It happens because compat_gpr_get and compat_gpr_set functions can
> > >> copy registers values to/from either kbuf or ubuf. ELF core file
> > >> collection function fill_thread_core_info calls compat_gpr_get
> > >> with kbuf set and ubuf set to 0. But current compat_gpr_get and
> > >> compat_gpr_set function handle copy to/from only ubuf case.
> > >>
> > >> Fix is to handle kbuf and ubuf as two separate cases in similar
> > >> way as other functions like user_regset_copyout, user_regset_copyin do.
> > >
> > > An alternative is to use set_fs when kbuf is set, then use
> > > copy_{to,from}_user for everything. However, given how ugly I find
> > > set_fs to start with, your patch looks good to me:
> > >
> > > Acked-by: Will Deacon <will.deacon@arm•com>
> >
> > Thank you for review. Please forgive my naive question, I've tried to
> > google it, but does not look I do a good job. Is there any special thing
> > I need to do, so you or Catalin would pick this up? I've posted patches
> > to Russell's patch system before but never dealt with arm64 patches.
> >
> > Or I just need to repost the patch to linux-arm-kernel with your
> > 'Acked-by' and Cc: stable at vger.kernel.org in it?
>
> Yes, please. Just repost the patch with those tags and we'll pick it up
> after the merge window. If you notice that we've forgotten, please give us a
> prod!
Also don't forget to cc us on the email, it's quicker this way.
Thanks.
--
Catalin
next prev parent reply other threads:[~2014-06-03 17:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 5:46 [PATCH] arm64: ptrace: fix empty registers set in prstatus of aarch32 process core Victor Kamensky
2014-06-03 5:46 ` Victor Kamensky
2014-06-03 14:46 ` Will Deacon
2014-06-03 16:27 ` Victor Kamensky
2014-06-03 16:33 ` Will Deacon
2014-06-03 17:11 ` Catalin Marinas [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-06-03 18:21 Victor Kamensky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603171148.GE10126@arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox