From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH V2 2/2] ARM: dts: DRA7: Add node for RTC
Date: Mon, 14 Jul 2014 23:59:28 -0700 [thread overview]
Message-ID: <20140715065928.GK20068@atomide.com> (raw)
In-Reply-To: <53C4A8F5.2000302@ti.com>
* Lokesh Vutla <lokeshvutla@ti•com> [140714 21:09]:
> On Monday 14 July 2014 09:53 PM, Tony Lindgren wrote:
> > * Lokesh Vutla <lokeshvutla@ti•com> [140714 07:47]:
> >>
> >> In my experiments I observed that when RTC regulator is switched
> >> off and switched on, there is an abort while accessing RTC registers.
> >
> > Right, then you know you have the right regulator :)
>
> Once we switch it off it is expected, but then if it is *switched on*
> it is expected that we should be able to access registers. Here there
> is an abort accessing these registers.
Most likely you need to also reconfigure the registers or
re-enable the clock or reset it at the interconnect too.
> >> After discussing with hardware team, it is confirmed that this
> >> LDO9 regulator powering RTC cannot be turned off when
> >> SoC is active and expected to be always on.
> >
> > Hmm but sounds like you already proved it can be idled? So
> > the regulator really should be managed by the driver?
>
> Actually I adapted the driver to support a power regulator.
> Then I observed that if rtc is loaded as a module there is
> an abort( which is happening because the regulator is disabled
> once and re-enabled). So when we checked with the hardware team,
> they confirmed that ldo9 should not be disabled.
Hmm so how is it enabled initially then?
To me it sounds like very standard stuff to reinitialize
a driver for any omap device when waking from suspend or
returning from off-idle. If the RTC device cannot be reset,
idled and re-initialized properly, there's something wrong
with the RTC driver, clocks, regulators, or hwmod data for
that device.
Regards,
Tony
next prev parent reply other threads:[~2014-07-15 6:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 12:37 [PATCH] ARM: DRA7: hwmod: add entry for RTCSS Sekhar Nori
2014-06-13 19:09 ` Paul Walmsley
2014-06-15 3:47 ` Paul Walmsley
2014-07-03 10:22 ` Rajendra Nayak
2014-07-06 0:32 ` Paul Walmsley
2014-07-09 8:35 ` [PATCH V2 0/2] ARM: DRA7: Add RTC hwmod and dt entries Lokesh Vutla
2014-07-09 8:35 ` [PATCH V2 1/2] ARM: DRA7: hwmod: Add data for RTC Lokesh Vutla
2014-07-22 10:19 ` Lokesh Vutla
2014-07-22 19:19 ` Paul Walmsley
2014-07-09 8:35 ` [PATCH V2 2/2] ARM: dts: DRA7: Add node " Lokesh Vutla
2014-07-09 9:12 ` Tony Lindgren
2014-07-09 9:32 ` Keerthy
2014-07-09 10:09 ` Tony Lindgren
2014-07-09 10:35 ` Keerthy
2014-07-09 10:50 ` Tony Lindgren
2014-07-09 10:56 ` Keerthy
2014-07-09 11:00 ` Tony Lindgren
2014-07-09 11:06 ` Keerthy
2014-07-14 14:45 ` Lokesh Vutla
2014-07-14 16:23 ` Tony Lindgren
2014-07-15 3:57 ` Keerthy
2014-07-15 4:07 ` Lokesh Vutla
2014-07-15 6:59 ` Tony Lindgren [this message]
2014-07-15 3:51 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715065928.GK20068@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox