From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS
Date: Thu, 24 Jul 2014 00:42:36 +0200 [thread overview]
Message-ID: <20140723224236.GC28485@lunn.ch> (raw)
In-Reply-To: <1406154923-13612-2-git-send-email-yahoo@perenite.com>
> + i2c at 11000 {
> + compatible = "marvell,mv78230-a0-i2c",
> + "marvell,mv64xxx-i2c";
Ah sorry, i missed this first time. Do you really need
"marvell,mv78230-a0-i2c"?
Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt says:
- "marvell,mv78230-a0-i2c"
* Note: Only use "marvell,mv78230-a0-i2c" for a
very rare, initial version of the SoC which
had broken offload support. Linux
auto-detects this and sets it appropriately.
So i don't think you should have this hear.
Gregory, please could you comment.
> + power-led {
> + label = "ix4-300d:power";
It is normal to include the colour, and you did for all the other
LEDs.
Andrew
next prev parent reply other threads:[~2014-07-23 22:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 22:35 [PATCH 1/2] Adding Lenovo - Lenovo Group Ltd. to the vendor-prefixes list Benoit Masson
2014-07-23 22:32 ` Andrew Lunn
2014-07-23 22:35 ` [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Benoit Masson
2014-07-23 22:42 ` Andrew Lunn [this message]
2014-07-23 22:56 ` Benoit Masson
2014-07-23 22:58 ` Andrew Lunn
[not found] ` <10A7C530-7CD2-4ED0-889A-7FAC1922320F@perenite.com>
2014-07-23 23:15 ` Jason Cooper
2014-07-24 12:21 ` Gregory CLEMENT
2014-07-24 12:45 ` Jason Cooper
2014-07-24 13:29 ` Andrew Lunn
[not found] ` <C2E7C8C1-1198-4785-AB9C-C27B5E27A8D4@perenite.com>
2014-07-24 14:07 ` Jason Cooper
2014-07-24 14:29 ` Andrew Lunn
2014-07-24 14:56 ` Jason Cooper
2014-07-24 12:45 ` [PATCH 1/2] Adding Lenovo - Lenovo Group Ltd. to the vendor-prefixes list Rob Herring
2014-07-28 13:43 ` Jason Cooper
-- strict thread matches above, loose matches on Subject: below --
2014-07-23 22:52 [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Benoit Masson
2014-07-23 23:27 ` Jason Cooper
2014-07-23 23:29 ` Andrew Lunn
2014-07-23 23:42 ` Jason Cooper
2014-07-24 12:11 ` Jason Cooper
2014-07-24 4:00 ` Baruch Siach
2014-07-26 17:26 ` Andrew Lunn
2014-07-26 23:55 ` Benoit Masson
2014-07-26 23:47 Benoit Masson
2014-07-27 1:52 ` Andrew Lunn
2014-07-28 8:49 ` Arnd Bergmann
2014-07-28 10:50 ` Benoit Masson
2014-07-28 11:02 ` Arnd Bergmann
2014-07-28 11:17 ` Benoit Masson
2014-07-28 11:37 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140723224236.GC28485@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox