From: greg@kroah•com (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] imx-drm: imx-drm-core: add suspend/resume support
Date: Tue, 19 Aug 2014 04:16:41 -0500 [thread overview]
Message-ID: <20140819091641.GA1349@kroah.com> (raw)
In-Reply-To: <20140819080808.GB30401@n2100.arm.linux.org.uk>
On Tue, Aug 19, 2014 at 09:08:08AM +0100, Russell King - ARM Linux wrote:
> On Mon, Aug 18, 2014 at 02:25:34PM +0800, Shawn Guo wrote:
> > On Fri, Jul 25, 2014 at 02:20:40PM +0800, Shawn Guo wrote:
> > > HDMI currently stops working after a system suspend/resume cycle. The
> > > cause is that the mode setting states in hardware gets lost and isn't
> > > restored across the suspend/resume cycle.
> > >
> > > The patch adds a very basic suspend/resume support to imx-drm driver,
> > > and calls drm_helper_resume_force_mode() in .resume hook to restore the
> > > mode setting states, so that HDMI can continue working after a system
> > > suspend/resume cycle.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@freescale•com>
> >
> > Hi Russell,
> >
> > What's your take on this patch?
>
> I've mostly stepped away from collecting imx-drm patches for Greg, and
> I'm probably going to be dropping those patches which I had queued up
> a while back for Greg.
>
> Greg wishes me to use signed tags for pull requests. This is not how I
> work, and would mean having to rewrite a bunch of my scripts to cater
> for Greg's special case. No one else requires this.
"special case"? That's what Linus wants from everyone as well, how hard
is it to add a simple line to your scripts that does:
git tag -u ${KEY} -s ${TREE} ${BRANCH}
before doing:
git request-pull .... ${TREE}
It's just a simple one line addition, right? What am I missing here?
> I haven't had the time to start looking at what this would require
> during the last three months, so the only other solution is to step
> down from dealing with imx-drm patches.
I never said I would refuse to take patches from you if you didn't do
this, I only asked if you could, as it makes me feel more comfortable
taking pull requests from you as you are the only one that doesn't do
this for trees I pull.
You should be using signed tags for your other trees as well, it's not
just me who should be asking you for this...
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-19 9:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 6:20 [PATCH v2] imx-drm: imx-drm-core: add suspend/resume support Shawn Guo
2014-08-18 6:25 ` Shawn Guo
2014-08-19 8:08 ` Russell King - ARM Linux
2014-08-19 9:16 ` Greg KH [this message]
2014-08-19 9:42 ` Russell King - ARM Linux
2014-08-18 7:43 ` Andrzej Hajda
2014-08-18 12:38 ` Shawn Guo
2014-08-18 12:58 ` Andrzej Hajda
2014-08-18 13:11 ` Andrzej Hajda
2014-08-19 7:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819091641.GA1349@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox