Subject: [PATCH v2 3/4] arm64, thunder: Document devicetree bindings for Cavium Thunder SoC

From: [email-masked] (Mark Rutland)
Date: Fri, 5 Sep 2014 10:39:33 +0100

On Fri, Sep 05, 2014 at 10:32:22AM +0100, Robert Richter wrote:
> On 05.09.14 09:42:00, Will Deacon wrote:
> > On Fri, Sep 05, 2014 at 08:46:44AM +0100, Robert Richter wrote:
> > > From: Radha Mohan Chintakuntla <[email-masked]>
> > > 
> > > This patch adds documentation for the devicetree bindings used by the
> > > DT files of Cavium Thunder SoC platforms.
> > > 
> > > Signed-off-by: Radha Mohan Chintakuntla <[email-masked]>
> > > Signed-off-by: Robert Richter <[email-masked]>
> > > ---
> > >  Documentation/devicetree/bindings/arm/cavium-thunder.txt | 10 ++++++++++
> > >  Documentation/devicetree/bindings/arm/cpus.txt           |  1 +
> > >  2 files changed, 11 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/arm/cavium-thunder.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/arm/cavium-thunder.txt b/Documentation/devicetree/bindings/arm/cavium-thunder.txt
> > > new file mode 100644
> > > index 000000000000..6f63a5866902
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/arm/cavium-thunder.txt
> > > @@ -0,0 +1,10 @@
> > > +Cavium Thunder platform device tree bindings
> > > +--------------------------------------------
> > > +
> > > +Boards with Cavium's Thunder SoC shall have following properties.
> > > +
> > > +Root Node
> > > +---------
> > > +Required root node properties:
> > > +
> > > +  - compatible = "cavium,thunder-88xx";
> > 
> > Is this file necessary? We don't have one for xgene afaict.
> 
> Hmm, looking at Documentation/devicetree/bindings/arm/calxeda.txt
> there is something similar.
> 
> I am fine with both, keeping or removing it.
> 
> Would leave this to the DT maintainers.

Having a required root node compatible is fine, though I would only
expect it to be necessary for errata workarounds if we have no other way
of detecting things.

That said, compatible strings shouldn't have wildcards, so
"cavium,thunder-88xx" should be replaced with something more specific.
Later boards can claim compatibility with that (but should have their
own strings too).

Mark.