From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCHv4 2/2] arm64: Add CONFIG_DEBUG_SET_MODULE_RONX support
Date: Wed, 10 Sep 2014 09:47:05 +0100 [thread overview]
Message-ID: <20140910084705.GB28488@arm.com> (raw)
In-Reply-To: <CAMDttNf9nWutGNVT8f+f99SX8WtDNSBDN4uvpS+oJKNMdXs7xQ@mail.gmail.com>
On Wed, Sep 10, 2014 at 04:58:01AM +0100, Zi Shen Lim wrote:
> On Mon, Sep 1, 2014 at 8:45 AM, Will Deacon <will.deacon@arm•com> wrote:
> > On Mon, Sep 01, 2014 at 04:42:20PM +0100, Laura Abbott wrote:
> >> On 8/26/2014 7:40 AM, Catalin Marinas wrote:
> >> > On Tue, Aug 19, 2014 at 08:41:43PM +0100, Laura Abbott wrote:
> >> >> --- /dev/null
> >> >> +++ b/arch/arm64/mm/pageattr.c
> >> > [...]
> >> >> +static int change_memory_common(unsigned long addr, int numpages,
> >> >> + pgprot_t set_mask, pgprot_t clear_mask)
> >> >> +{
> >> >> + unsigned long start = addr;
> >> >> + unsigned long size = PAGE_SIZE*numpages;
> >> >> + unsigned long end = start + size;
> >> >> + int ret;
> >> >> + struct page_change_data data;
> >> >> +
> >> >> + if (!IS_ALIGNED(addr, PAGE_SIZE)) {
> >> >> + addr &= PAGE_MASK;
>
> I don't see any uses of addr after this.
> Perhaps we also meant to compute start and end?
Actually, I think the alignment fixup should just be performed directly on
start, but this is Laura's code so it would be good if she could confirm.
Laura -- what's the right thing to do here? (sending a fix patch would be
ideal :)
Will
next prev parent reply other threads:[~2014-09-10 8:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 19:41 [PATCHv4 0/2] arm64 CONFIG_DEBUG_SET_MODULE_RONX support Laura Abbott
2014-08-19 19:41 ` [PATCHv4 1/2] arm64: Introduce {set,clear}_pte_bit Laura Abbott
2014-08-26 14:27 ` Catalin Marinas
2014-08-26 20:15 ` Laura Abbott
2014-08-27 8:07 ` Will Deacon
2014-09-01 15:42 ` Laura Abbott
2014-08-19 19:41 ` [PATCHv4 2/2] arm64: Add CONFIG_DEBUG_SET_MODULE_RONX support Laura Abbott
2014-08-26 14:40 ` Catalin Marinas
2014-09-01 15:42 ` Laura Abbott
2014-09-01 15:45 ` Will Deacon
2014-09-10 3:58 ` Zi Shen Lim
2014-09-10 8:47 ` Will Deacon [this message]
2014-09-11 4:42 ` Laura Abbott
2014-09-11 22:10 ` [PATCH] arm64: pageattr: Correctly adjust unaligned start addresses Laura Abbott
2014-09-12 3:40 ` Z Lim
2014-09-12 15:36 ` Catalin Marinas
2014-08-22 17:36 ` [PATCHv4 0/2] arm64 CONFIG_DEBUG_SET_MODULE_RONX support Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910084705.GB28488@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox