From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang
Date: Mon, 15 Sep 2014 17:02:41 +0100 [thread overview]
Message-ID: <20140915160240.GC29744@arm.com> (raw)
In-Reply-To: <1410759015-15642-1-git-send-email-behanw@converseincode.com>
On Mon, Sep 15, 2014 at 06:30:15AM +0100, behanw at converseincode.com wrote:
> From: Mark Charlebois <charlebm@gmail•com>
>
> Remove '#' from immediate parameter in AARCH64 inline assembly in mmu.
>
> This code now works with both gcc and clang.
>
> Signed-off-by: Mark Charlebois <charlebm@gmail•com>
> Signed-off-by: Behan Webster <behanw@converseincode•com>
> ---
> arch/arm64/mm/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Will Deacon <will.deacon@arm•com>
Thanks, Behan!
Catalin: please can you pick this up for 3.18? It's probably not worth me
merging it as a fix, since there are other patches needed to get us building
under clang anyway.
Will
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index c555672..6894ef3 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -94,7 +94,7 @@ static int __init early_cachepolicy(char *p)
> */
> asm volatile(
> " mrs %0, mair_el1\n"
> - " bfi %0, %1, #%2, #8\n"
> + " bfi %0, %1, %2, #8\n"
> " msr mair_el1, %0\n"
> " isb\n"
> : "=&r" (tmp)
> --
> 1.9.1
>
>
next prev parent reply other threads:[~2014-09-15 16:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 23:24 [PATCH] arm64: LLVMLinux: Fix inline arm64 assembly for use with clang behanw at converseincode.com
2014-09-08 9:30 ` Olof Johansson
2014-09-10 17:38 ` Will Deacon
2014-09-10 17:49 ` Ard Biesheuvel
2014-09-08 10:53 ` Will Deacon
2014-09-08 18:35 ` Mark Charlebois
2014-09-09 10:15 ` Will Deacon
2014-09-15 5:30 ` behanw at converseincode.com
2014-09-15 16:02 ` Will Deacon [this message]
2014-09-15 16:26 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915160240.GC29744@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox