From: lina.iyer@linaro•org (Lina Iyer)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 1/5] qcom: spm: Add Subsystem Power Manager driver
Date: Fri, 26 Sep 2014 11:19:30 -0600 [thread overview]
Message-ID: <20140926171930.GF390@ilina-mac.local> (raw)
In-Reply-To: <7h61ga48sq.fsf@deeprootsystems.com>
On Fri, Sep 26 2014 at 10:59 -0600, Kevin Hilman wrote:
>Lina Iyer <lina.iyer@linaro•org> writes:
>
>> Based on work by many authors, available at codeaurora.org
>>
>> SPM is a hardware block that controls the peripheral logic surrounding
>> the application cores (cpu/l$). When the core executes WFI instruction,
>> the SPM takes over the putting the core in low power state as
>> configured. The wake up for the SPM is an interrupt at the GIC, which
>> then completes the rest of low power mode sequence and brings the core
>> out of low power mode.
>>
>> The SPM has a set of control registers that configure the SPMs
>> individually based on the type of the core and the runtime conditions.
>> SPM is a finite state machine block to which a sequence is provided and
>> it interprets the bytes and executes them in sequence. Each low power
>> mode that the core can enter into is provided to the SPM as a sequence.
>>
>> Configure the SPM to set the core (cpu or L2) into its low power mode,
>> the index of the first command in the sequence is set in the SPM_CTL
>> register. When the core executes ARM wfi instruction, it triggers the
>> SPM state machine to start executing from that index. The SPM state
>> machine waits until the interrupt occurs and starts executing the rest
>> of the sequence until it hits the end of the sequence. The end of the
>> sequence jumps the core out of its low power mode.
>>
>> Signed-off-by: Lina Iyer <lina.iyer@linaro•org>
>
>[...]
>
>> +enum {
>> + MSM_SPM_REG_SAW2_CFG,
>> + MSM_SPM_REG_SAW2_AVS_CTL,
>> + MSM_SPM_REG_SAW2_AVS_HYSTERESIS,
>Do you really need the MSM_SPM_REG_ prefix on all of these? As these
>names are all local to the driver, the extra prefix isn't needed IMO.
>
Nope, I dont.. I will remove them.
>Also, consdiering that SPM seems to be sub-block of SAW2, the fact that
>the SPM shows up twice in some of the names is a bit confusing.
>
I understand. I will fix that.
>
next prev parent reply other threads:[~2014-09-26 17:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 23:51 [PATCH v6 0/5] QCOM 8074 cpuidle driver Lina Iyer
2014-09-23 23:51 ` [PATCH v6 1/5] qcom: spm: Add Subsystem Power Manager driver Lina Iyer
2014-09-24 1:58 ` Lina Iyer
2014-09-24 16:33 ` Kumar Gala
2014-09-24 17:21 ` Lina Iyer
2014-09-24 17:53 ` Kumar Gala
2014-09-24 19:29 ` Lina Iyer
2014-09-26 14:45 ` Lina Iyer
2014-09-26 14:53 ` Kumar Gala
2014-09-26 15:07 ` Lina Iyer
2014-09-24 17:43 ` Josh Cartwright
2014-09-24 19:01 ` Lina Iyer
2014-09-24 18:07 ` Kumar Gala
2014-09-24 18:47 ` Lina Iyer
2014-09-26 19:04 ` Kevin Hilman
2014-09-26 19:12 ` Lina Iyer
2014-09-26 19:30 ` Kevin Hilman
2014-09-26 16:59 ` Kevin Hilman
2014-09-26 17:19 ` Lina Iyer [this message]
2014-09-23 23:51 ` [PATCH v6 2/5] arm: dts: qcom: Add SPM device bindings for 8974 Lina Iyer
2014-09-24 6:18 ` Pramod Gurav
2014-09-24 13:49 ` Lina Iyer
2014-09-24 14:03 ` Kumar Gala
2014-09-24 14:13 ` Lina Iyer
2014-09-24 17:21 ` Stephen Boyd
2014-09-24 17:23 ` Lina Iyer
2014-09-24 21:46 ` Stephen Boyd
2014-09-23 23:51 ` [PATCH v6 3/5] qcom: msm-pm: Add cpu low power mode functions Lina Iyer
2014-09-23 23:51 ` [PATCH v6 4/5] qcom: cpuidle: Add cpuidle driver for QCOM cpus Lina Iyer
2014-09-23 23:51 ` [PATCH v6 5/5] arm: dts: qcom: Add idle states device nodes for 8974 Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926171930.GF390@ilina-mac.local \
--to=lina.iyer@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox