From: linux@roeck-us•net (Guenter Roeck)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog
Date: Thu, 9 Oct 2014 08:59:18 -0700 [thread overview]
Message-ID: <20141009155918.GD31987@roeck-us.net> (raw)
In-Reply-To: <20141009071740.GK20647@lee--X1>
On Thu, Oct 09, 2014 at 08:17:40AM +0100, Lee Jones wrote:
> On Wed, 08 Oct 2014, Guenter Roeck wrote:
>
> > On Wed, Oct 08, 2014 at 10:33:30AM +0100, Lee Jones wrote:
> > > Signed-off-by: David Paris <david.paris@st•com>
> > > Signed-off-by: Lee Jones <lee.jones@linaro•org>
> > > ---
> > > drivers/watchdog/Kconfig | 16 +++
> > > drivers/watchdog/Makefile | 1 +
> > > drivers/watchdog/st_wdt.c | 317 ++++++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 334 insertions(+)
> > > create mode 100644 drivers/watchdog/st_wdt.c
> > >
> >
> > Unfortunately (built with W=1):
> >
> > drivers/watchdog/st_wdt.c: In function 'st_wdog_load_timer':
> > drivers/watchdog/st_wdt.c:114:14: warning: comparison between signed and
> > unsigned integer expressions [-Wsign-compare]
> > drivers/watchdog/st_wdt.c: In function 'st_wdog_remove':
> > drivers/watchdog/st_wdt.c:273:24: error: 'clk' undeclared (first use in this
> > function)
> >
> > and checkpatch complains a bit:
> >
> > WARNING: please, no space before tabs
> > #303: FILE: drivers/watchdog/st_wdt.c:236:
> > +^Ist_wdog->dev ^I^I= &pdev->dev;$
> >
> > WARNING: please, no space before tabs
> > #304: FILE: drivers/watchdog/st_wdt.c:237:
> > +^Ist_wdog->base ^I^I= base;$
> >
> > WARNING: please, no space before tabs
> > #306: FILE: drivers/watchdog/st_wdt.c:239:
> > +^Ist_wdog->warm_reset ^I= of_property_read_bool(np, "st,warm_reset");$
>
> Thanks for taking the time to build this Guenter. I must profess, the
> recent submissions were delivered hastily, due to other pressing tasks
> and a mountain of email to peruse. The next submission will be
> subject extensive; build, static analysis and execution testing.
> Sorry to waste your time.
>
No worries. This is just part of my workflow, and it can happen to all of us.
Guenter
next prev parent reply other threads:[~2014-10-09 15:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 9:33 [PATCH v3 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-08 9:33 ` [PATCH 1/4] ARM: STi: DT: STiH407: Add Device Tree node for LPC Watchdog Lee Jones
2014-10-08 9:33 ` [PATCH 2/4] ARM: multi_v7_defconfig: Enable support for ST's " Lee Jones
2014-10-08 9:33 ` [PATCH 3/4] watchdog: st_wdt: Provide binding documentation for ST's LPC Watchdog driver Lee Jones
2014-10-09 9:56 ` Mark Rutland
2014-10-23 15:02 ` Lee Jones
2014-10-08 9:33 ` [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-10-08 15:57 ` Guenter Roeck
2014-10-09 7:17 ` Lee Jones
2014-10-09 15:59 ` Guenter Roeck [this message]
2014-10-09 10:01 ` Mark Rutland
2014-10-09 10:50 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2014-10-23 15:18 [PATCH v4 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-23 15:18 ` [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-10-23 15:23 ` Arnd Bergmann
2014-10-07 14:36 [PATCH v2 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-10-07 14:36 ` [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-10-07 17:23 ` Guenter Roeck
2014-09-04 14:39 [PATCH 0/4] watchdog: Introduce new driver to support ST's Watchdog Lee Jones
2014-09-04 14:39 ` [PATCH 4/4] watchdog: st_wdt: Add new driver for ST's LPC Watchdog Lee Jones
2014-09-05 15:58 ` Guenter Roeck
2014-09-08 12:32 ` Lee Jones
2014-09-08 13:31 ` Guenter Roeck
2014-09-08 14:35 ` Lee Jones
2014-09-22 7:36 ` David Paris
2014-09-22 10:24 ` David Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141009155918.GD31987@roeck-us.net \
--to=linux@roeck-us$(echo .)net \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox