Subject: next build: 304 warnings 0 failures (next/next-20141013)

From: [email-masked] (Mika Westerberg)
Date: Tue, 14 Oct 2014 16:16:43 +0300

On Tue, Oct 14, 2014 at 11:17:33AM +0200, Arnd Bergmann wrote:
> On Tuesday 14 October 2014 11:54:32 Mika Westerberg wrote:
> > 
> > Fenghua's build bot noticed this some time ago and it got fixed but
> > looks like we forgot to merge the fix to the _DSD patch series.
> > 
> > Here it is again. Rafael, do you want to take this on top of the
> > 'device-properties' -branch?
> > 
> > From: Mika Westerberg <[email-masked]>
> > Subject: [PATCH] leds: Move gpiod to be last member of struct gpio_led
> > 
> > Commit 8b0d4dc3d44 (leds: leds-gpio: Add support for GPIO descriptors)
> > added a new member 'gpiod' to struct gpio_led to support GPIO descriptors.
> > This is fine as long as board files use designated initializers but some
> > fail to do so causing following build errors:
> > 
> >   arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default]
> >   arch/arm/mach-omap1/board-htcherald.c:296:2: warning: (near initialization for 'gpio_leds[0].gpiod') [enabled by default]
> >   arch/arm/mach-omap1/board-htcherald.c:297:2: warning: initialization makes pointer from integer without a cast [enabled by default]
> >   arch/arm/mach-omap1/board-htcherald.c:297:2: warning: (near initialization for 'gpio_leds[1].gpiod') [enabled by default]
> > 
> > To be on the safe side move the 'gpiod' member to be the last member of struct
> > gpiod_led.
> > 
> > Signed-off-by: Mika Westerberg <[email-masked]>
> > 
> 
> Acked-by: Arnd Bergmann <[email-masked]>
> 
> Looks good to me. Should we also do the other patch to be on the safe side?

I think it is good idea.

> 8<-------
> Subject: [PATCH] ARM: OMAP1: htcherald: use named initializers for gpio-leds
> 
> A recent change to the gpio-leds driver broke the platform data definition
> in the htcherald file:
> 
> arch/arm/mach-omap1/board-htcherald.c:296:2: warning: initialization makes pointer from integer without a cast [enabled by default]
> 
> The gpio-led driver is being changed to avoid that problem, but it would also
> be good to make the board file use named initializers like every other one,
> so it won't happen again.
> 
> Signed-off-by: Arnd Bergmann <[email-masked]>

FWIW,

Reviewed-by: Mika Westerberg <[email-masked]>