From: greg@kroah•com (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 2/2] [usb] add support for ACPI identification to xhci-platform
Date: Wed, 5 Nov 2014 14:05:03 -0800 [thread overview]
Message-ID: <20141105220503.GA15806@kroah.com> (raw)
In-Reply-To: <27218849.Pn0nHB6Dj3@wuerfel>
On Wed, Nov 05, 2014 at 09:41:23PM +0100, Arnd Bergmann wrote:
> On Wednesday 05 November 2014 11:55:07 Greg KH wrote:
> > On Wed, Nov 05, 2014 at 01:44:43PM -0600, Mark Langsdorf wrote:
> > > On 11/05/2014 01:11 PM, Greg KH wrote:
> > > >On Wed, Nov 05, 2014 at 07:59:32AM -0600, Mark Langsdorf wrote:
> > > >>>> static struct platform_driver usb_xhci_driver = {
> > > >>>> .probe = xhci_plat_probe,
> > > >>>> .remove = xhci_plat_remove,
> > > >>>>@@ -294,6 +304,7 @@ static struct platform_driver usb_xhci_driver = {
> > > >>>> .name = "xhci-hcd",
> > > >>>> .pm = DEV_PM_OPS,
> > > >>>> .of_match_table = of_match_ptr(usb_xhci_of_match),
> > > >>>>+ .acpi_match_table = ACPI_PTR(usb_xhci_acpi_match),
> > > >>>
> > > >>>Shouldn't the reworked driver core code handle this differently with the
> > > >>>ability to handle either OF or ACPI in the same driver?
> > > >>
> > > >>I'm not sure I understand the question. With these changes, the driver
> > > >>handles both ACPI and DTB/OF. It's the same style of code as used
> > > >>in drivers/ata/plat-xgene.c, which also handles both ACPI and DTB/OF.
> > > >>Why do you think this code isn't correct?
> > > >
> > > >There is a new framework in the kernel that keeps a driver from having
> > > >to query both of and acpi to get the needed resources, it just does one
> > > >query and depending on the platform, everything "just works". Shouldn't
> > > >that be used here as well?
> > >
> > > Would you send me a pointer to a driver that's using this new
> > > framework? I can't find any references to it and all the other
> > > drivers that support ACPI and OF are doing it the way I'm doing
> > > it.
> >
> > See the email on lkml:
> > Subject: [PATCH v6 00/12] Add ACPI _DSD and unified device properties support
> >
> > for the latest patch series.
> >
>
> The _DSD approach is for devices that do not follow the ACPI specification
> but do have a DT binding. Those will work without the .acpi_match_table
> entry when the firmware uses the compatible value in the new properties.
>
> In this case, the device does have an official ACPI ID "PNP0D10", so we should
> use that for compatibility with other operating systems and with BIOS
> versions that provide the standard IDs.
Ah, ok, nevermind then, sorry for the noise, I wasn't aware of this.
greg k-h
next prev parent reply other threads:[~2014-11-05 22:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 18:16 [usb] add support for APM X-Gene to xhci-platform Mark Langsdorf
2014-10-30 18:16 ` [PATCH 1/2] [usb] make xhci platform driver use 64 bit or 32 bit DMA Mark Langsdorf
2014-10-30 19:05 ` Arnd Bergmann
2014-10-30 20:09 ` Mark Langsdorf
2014-10-30 21:05 ` Arnd Bergmann
2014-10-31 14:22 ` Mark Langsdorf
2014-10-31 15:49 ` Arnd Bergmann
2014-10-31 17:32 ` Mark Langsdorf
2014-10-31 19:41 ` Arnd Bergmann
2014-11-03 14:15 ` Mark Salter
2014-11-03 17:14 ` Arnd Bergmann
2014-11-03 18:45 ` Mark Salter
2014-11-04 17:33 ` Al Stone
2014-11-06 0:03 ` Arnd Bergmann
2014-11-04 16:50 ` [PATCH v2 " Mark Langsdorf
2014-11-04 16:50 ` [PATCH v2 2/2] [usb] add support for ACPI identification to xhci-platform Mark Langsdorf
2014-11-04 17:12 ` Greg KH
2014-11-05 13:59 ` Mark Langsdorf
2014-11-05 19:11 ` Greg KH
2014-11-05 19:44 ` Mark Langsdorf
2014-11-05 19:55 ` Greg KH
2014-11-05 20:41 ` Arnd Bergmann
2014-11-05 22:05 ` Greg KH [this message]
2014-11-13 18:36 ` Mark Langsdorf
2014-11-13 19:08 ` Greg KH
2014-11-18 20:05 ` Feng Kan
2014-11-18 20:33 ` Mark Langsdorf
2014-11-18 21:11 ` Feng Kan
2014-10-30 18:16 ` [PATCH 2/2] [usb] add support for APM X-Gene " Mark Langsdorf
2014-10-30 19:07 ` Arnd Bergmann
2014-10-30 20:12 ` Mark Langsdorf
2014-10-30 20:53 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105220503.GA15806@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox