From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header
Date: Fri, 21 Nov 2014 08:15:30 -0800 [thread overview]
Message-ID: <20141121161529.GQ7046@atomide.com> (raw)
In-Reply-To: <546F05C3.6090508@ti.com>
* Roger Quadros <rogerq@ti•com> [141121 01:30]:
> On 11/21/2014 12:28 AM, Tony Lindgren wrote:
> > +#include <linux/omap-gpmc.h>
> > +#include <linux/platform_data/omap-gpmc.h>
>
> I think we should get rid for mach-omap2/gpmc.h and include the above two
> headers wherever needed.
Well I'm trying to keep the churn on patching all board-*.c files
down to minimum until they just get dropped.
So let's keep gpmc.h around still for a little while for all the
board-*.c files.
> > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> > index 175564c..88721df 100644
> > --- a/arch/arm/mach-omap2/pm34xx.c
> > +++ b/arch/arm/mach-omap2/pm34xx.c
> > @@ -29,6 +29,7 @@
> > #include <linux/delay.h>
> > #include <linux/slab.h>
> > #include <linux/omap-dma.h>
> > +#include <linux/omap-gpmc.h>
> > #include <linux/platform_data/gpio-omap.h>
> >
> > #include <trace/events/power.h>
> > @@ -43,7 +44,6 @@
> > #include "common.h"
> > #include "cm3xxx.h"
> > #include "cm-regbits-34xx.h"
> > -#include "gpmc.h"
> > #include "prm-regbits-34xx.h"
> > #include "prm3xxx.h"
> > #include "pm.h"
And for the files that will stay around, let's not include gpmc.h.
> > --- /dev/null
> > +++ b/include/linux/platform_data/omap-gpmc.h
> > @@ -0,0 +1,177 @@
> > +/*
> > + * General-Purpose Memory Controller for OMAP2
> > + *
> > + * Copyright (C) 2005-2006 Nokia Corporation
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> > +
> > +#ifndef __OMAP2_GPMC_H
> > +#define __OMAP2_GPMC_H
> > +
> > +#include <linux/platform_data/mtd-nand-omap2.h>
>
> Why do need to include this header here?
Probably left over from the old code, that looks unnecessary.
Regards,
Tony
next prev parent reply other threads:[~2014-11-21 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 22:28 [PATCH 0/3] Move omap GPMC to live in drivers/bus Tony Lindgren
2014-11-20 22:28 ` [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header Tony Lindgren
2014-11-21 9:28 ` Roger Quadros
2014-11-21 16:15 ` Tony Lindgren [this message]
2014-11-21 16:55 ` Tony Lindgren
2014-11-20 22:28 ` [PATCH 2/3] ARM: OMAP2+: Move GPMC initcall to devices.c Tony Lindgren
2014-11-21 9:41 ` Roger Quadros
2014-11-21 16:17 ` Tony Lindgren
2014-11-20 22:28 ` [PATCH 3/3] drivers: bus: Move omap gpmc code to live under drivers Tony Lindgren
2014-11-21 8:05 ` Lokesh Vutla
2014-11-21 17:18 ` Tony Lindgren
2014-11-21 9:15 ` Roger Quadros
2014-11-21 11:15 ` Arnd Bergmann
2014-11-21 16:18 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2014-11-21 18:34 [PATCHv2 0/3] Move omap GPMC to live in drivers/memory Tony Lindgren
2014-11-21 18:34 ` [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header Tony Lindgren
2014-11-26 11:28 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141121161529.GQ7046@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox