public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: tony@atomide•com (Tony Lindgren)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] memory: gpmc: Move omap gpmc code to live under drivers
Date: Fri, 21 Nov 2014 10:45:34 -0800	[thread overview]
Message-ID: <20141121184533.GV7046@atomide.com> (raw)
In-Reply-To: <20141121183911.GA7508@saruman>

* Felipe Balbi <balbi@ti•com> [141121 10:40]:
> On Fri, Nov 21, 2014 at 10:34:16AM -0800, Tony Lindgren wrote:
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -41,6 +41,14 @@ config TI_EMIF
> >  	  parameters and other settings during frequency, voltage and
> >  	  temperature changes
> >  
> > +config OMAP_GPMC
> > +	bool
> 
> shouldn't you make this selectable ? I might want to build a kernel
> without GPMC support because my board just doesn't use GPMC :-)

Eventually yes, but let's keep it separate from this move. We'd have
to do something like this:

- Make omap MTD drivers depend on OMAP_GPMC

- Make tusb6010 depend on OMAP_GPMC

- Make smc911x depend on OMAP_GPMC

- Build arch/arm/mach-omap2/*gpmc*.c conditionally
  depending on OMAP_GPMC

Adding stubs for omap-gpmc probably does not make sense as these
devices really depend on GPMC.

Regards,

Tony

  reply	other threads:[~2014-11-21 18:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 18:34 [PATCHv2 0/3] Move omap GPMC to live in drivers/memory Tony Lindgren
2014-11-21 18:34 ` [PATCH 1/3] ARM: OMAP2+: Prepare to move GPMC to drivers by platform data header Tony Lindgren
2014-11-26 11:28   ` Roger Quadros
2014-11-21 18:34 ` [PATCH 2/3] ARM: OMAP2+: Move GPMC initcall to devices.c Tony Lindgren
2014-11-21 18:34 ` [PATCH 3/3] memory: gpmc: Move omap gpmc code to live under drivers Tony Lindgren
2014-11-21 18:39   ` Felipe Balbi
2014-11-21 18:45     ` Tony Lindgren [this message]
2014-11-24 10:00   ` Roger Quadros
2014-11-24 15:44     ` Tony Lindgren
2014-11-26 11:22       ` Roger Quadros
2014-11-26 20:10         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141121184533.GV7046@atomide.com \
    --to=tony@atomide$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox