From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: Add FIX_HOLE to permanent fixed addresses
Date: Wed, 26 Nov 2014 11:32:32 +0000 [thread overview]
Message-ID: <20141126113232.GB14866@arm.com> (raw)
In-Reply-To: <1416960856-2944-1-git-send-email-lauraa@codeaurora.org>
On Wed, Nov 26, 2014 at 12:14:16AM +0000, Laura Abbott wrote:
> Every other architecture with permanent fixed addresses has
> FIX_HOLE as the first entry. This seems to be designed as a
> debugging aid but there are a couple of side effects of not
> having FIX_HOLE:
>
> - If the first fixed address is 0, fix_to_virt -> virt_to_fix
> triggers a BUG_ON for the virtual address being equal to
> FIXADDR_TOP
> - fix_to_virt may return a value outside of FIXADDR_START
> and FIXADDR_TOP which may look like a bug to a developer.
>
> Match up with other architectures and make everything clearer
> by adding FIX_HOLE.
>
> Signed-off-by: Laura Abbott <lauraa@codeaurora•org>
> ---
> arch/arm64/include/asm/fixmap.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h
> index 5f7bfe6..424a10f 100644
> --- a/arch/arm64/include/asm/fixmap.h
> +++ b/arch/arm64/include/asm/fixmap.h
> @@ -31,6 +31,7 @@
> *
> */
> enum fixed_addresses {
> + FIX_HOLE,
> FIX_EARLYCON_MEM_BASE,
> __end_of_permanent_fixed_addresses,
Looks sensible to me, thanks.
Will
prev parent reply other threads:[~2014-11-26 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 0:14 [PATCH] arm64: Add FIX_HOLE to permanent fixed addresses Laura Abbott
2014-11-26 11:32 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141126113232.GB14866@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox