Subject: [PATCH] arm: omap2: rx51-peripherals: fix build warning

From: [email-masked] (Mauro Carvalho Chehab)
Date: Thu, 4 Dec 2014 15:00:12 -0200

Em Thu, 04 Dec 2014 08:39:31 -0800
Tony Lindgren <[email-masked]> escreveu:

> * Felipe Balbi <[email-masked]> [141204 07:50]:
> > Hi,
> > 
> > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > > so that si4713 could be easily used on DT boot, but
> > > > > it ended up introducing a build warning whenever
> > > > > si4713 isn't enabled.
> > > > > 
> > > > > This patches fixes that warning:
> > > > > 
> > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > > 	?rx51_si4713_platform_data? defined but not used [-Wunused-variable]
> > > > >  static struct si4713_platform_data rx51_si4713_platform_data = {
> > > > > 
> > > > > Cc: Sebastian Reichel <[email-masked]>
> > > > > Cc: Tony Lindgren <[email-masked]>
> > > > > Cc: Hans Verkuil <[email-masked]>
> > > > > Cc: Mauro Carvalho Chehab <[email-masked]>
> > > > > Signed-off-by: Felipe Balbi <[email-masked]>
> > > > 
> > > > a gentle reminder on this one.
> > > > 
> > > 
> > > Let me add my
> > > 
> > > Acked-by: Arnd Bergmann <[email-masked]>
> > > 
> > > You didn't say who you expect to pick up the patch. I assume Mauro
> > 
> > patch author now decides who takes the patch ? That's new :-)

Well, for patches that cross subsystem boundaries, like this one,
the best is to give a hint about whom you expect to pick it.

In this specific case, as commit 68a3c04 is in my tree, the best is
to merge the patch on it, as the patch may not even apply at Tony's
tree.

> > 
> > > should take it because he took the patch that caused the problem,
> > > but he might not be aware that he should look at this now.
> > 
> > He is in Cc, let's ask him :-)
> 
> Best that this one goes in along with the other si4713 patches
> to avoid dependencies between trees:
> 
> Acked-by: Tony Lindgren <[email-masked]>

Thanks! I'll merge it via my tree.

Regards,
Mauro